moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: gadget: f_hid: fix endianness issue with descriptors

Browse Source 
[ Upstream commit 33cb46c467 ]

Running sparse checker it shows warning message about
incorrect endianness used for descriptor initialization:

| f_hid.c:91:43: warning: incorrect type in initializer (different base types)
| f_hid.c:91:43:    expected restricted __le16 [usertype] bcdHID
| f_hid.c:91:43:    got int

Fixing issue with cpu_to_le16() macro, however this is not a real issue
as the value is the same both endians.

Cc: Fabien Chouteau <fabien.chouteau@barco.com>
Cc: Segiy Stetsyuk <serg_stetsuk@ukr.net>
Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Link: https://lore.kernel.org/r/20210617162755.29676-1-ruslan.bilovol@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ruslan Bilovol
2021-06-17 19:27:55 +03:00
committed by Greg Kroah-Hartman
parent 16668cc656
commit 309b44d316
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/gadget/function/f_hid.c
View File

@@ -88,7 +88,7 @@ static struct usb_interface_descriptor hidg_interface_desc = {
static struct hid_descriptor hidg_desc = { static struct hid_descriptor hidg_desc = {
.bLength = sizeof hidg_desc, .bLength = sizeof hidg_desc,
.bDescriptorType = HID_DT_HID, .bDescriptorType = HID_DT_HID,
.bcdHID = 0x0101, .bcdHID = cpu_to_le16(0x0101),
.bCountryCode = 0x00, .bCountryCode = 0x00,
.bNumDescriptors = 0x1, .bNumDescriptors = 0x1,
/*.desc[0].bDescriptorType = DYNAMIC */ /*.desc[0].bDescriptorType = DYNAMIC */