gfs2: Fix underflow in gfs2_page_mkwrite
commitd3c51c55cbupstream. On filesystems with a block size smaller than PAGE_SIZE and non-empty files smaller then PAGE_SIZE, gfs2_page_mkwrite could end up allocating excess blocks beyond the end of the file, similar to fallocate. This doesn't make sense; fix it. Reported-by: Bob Peterson <rpeterso@redhat.com> Fixes:184b4e6085("gfs2: Fix end-of-file handling in gfs2_page_mkwrite") Cc: stable@vger.kernel.org # v5.5+ Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
b242ae99fa
commit
3ae1c663bd
@@ -474,8 +474,8 @@ static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf)
|
||||
file_update_time(vmf->vma->vm_file);
|
||||
|
||||
/* page is wholly or partially inside EOF */
|
||||
if (offset > size - PAGE_SIZE)
|
||||
length = offset_in_page(size);
|
||||
if (size - offset < PAGE_SIZE)
|
||||
length = size - offset;
|
||||
else
|
||||
length = PAGE_SIZE;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user