drm/rockchip: cdn-dp-core: add missing clk_disable_unprepare() on error in cdn_dp_grf_write()
[ Upstream commitae41d925c7] After calling clk_prepare_enable(), clk_disable_unprepare() need be called when calling regmap_write() failed. Fixes:1a0f7ed3ab("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Link: https://patchwork.freedesktop.org/patch/msgid/20210519134928.2696617-1-yangyingliang@huawei.com Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
ef61b0826c
commit
40492ebd29
@@ -73,6 +73,7 @@ static int cdn_dp_grf_write(struct cdn_dp_device *dp,
|
|||||||
ret = regmap_write(dp->grf, reg, val);
|
ret = regmap_write(dp->grf, reg, val);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
DRM_DEV_ERROR(dp->dev, "Could not write to GRF: %d\n", ret);
|
DRM_DEV_ERROR(dp->dev, "Could not write to GRF: %d\n", ret);
|
||||||
|
clk_disable_unprepare(dp->grf_clk);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user