moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ice: remove return variable

Browse Source 
We were saving the return value from ice_vsi_manage_rss_lut(), but
the errors from that function are not critical so change it to
return void and remove the code that saved the value.

Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
This commit is contained in:
Paul M Stillwell Jr
2021-03-31 14:17:07 -07:00
committed by Tony Nguyen
parent b370245b4b
commit 4fe3622694
3 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/intel/ice/ice_lib.c
View File

@@ -1313,14 +1313,13 @@ err_out:
* LUT, while in the event of enable request for RSS, it will reconfigure RSS * LUT, while in the event of enable request for RSS, it will reconfigure RSS
* LUT. * LUT.
*/ */
int ice_vsi_manage_rss_lut(struct ice_vsi *vsi, bool ena) void ice_vsi_manage_rss_lut(struct ice_vsi *vsi, bool ena)
{ {
int err = 0;
u8 *lut; u8 *lut;
lut = kzalloc(vsi->rss_table_size, GFP_KERNEL); lut = kzalloc(vsi->rss_table_size, GFP_KERNEL);
if (!lut) if (!lut)
return -ENOMEM; return;
if (ena) { if (ena) {
if (vsi->rss_lut_user) if (vsi->rss_lut_user)
@@ -1330,9 +1329,8 @@ int ice_vsi_manage_rss_lut(struct ice_vsi *vsi, bool ena)
vsi->rss_size); vsi->rss_size);
} }
err = ice_set_rss_lut(vsi, lut, vsi->rss_table_size); ice_set_rss_lut(vsi, lut, vsi->rss_table_size);
kfree(lut); kfree(lut);
return err;
} }
/** /**

2
drivers/net/ethernet/intel/ice/ice_lib.h
View File

@@ -85,7 +85,7 @@ void ice_vsi_free_rx_rings(struct ice_vsi *vsi);
void ice_vsi_free_tx_rings(struct ice_vsi *vsi); void ice_vsi_free_tx_rings(struct ice_vsi *vsi);
int ice_vsi_manage_rss_lut(struct ice_vsi *vsi, bool ena); void ice_vsi_manage_rss_lut(struct ice_vsi *vsi, bool ena);
void ice_update_tx_ring_stats(struct ice_ring *ring, u64 pkts, u64 bytes); void ice_update_tx_ring_stats(struct ice_ring *ring, u64 pkts, u64 bytes);

4
drivers/net/ethernet/intel/ice/ice_main.c
View File

@@ -5112,10 +5112,10 @@ ice_set_features(struct net_device *netdev, netdev_features_t features)
* separate if/else statements to guarantee each feature is checked * separate if/else statements to guarantee each feature is checked
*/ */
if (features & NETIF_F_RXHASH && !(netdev->features & NETIF_F_RXHASH)) if (features & NETIF_F_RXHASH && !(netdev->features & NETIF_F_RXHASH))
ret = ice_vsi_manage_rss_lut(vsi, true); ice_vsi_manage_rss_lut(vsi, true);
else if (!(features & NETIF_F_RXHASH) && else if (!(features & NETIF_F_RXHASH) &&
netdev->features & NETIF_F_RXHASH) netdev->features & NETIF_F_RXHASH)
ret = ice_vsi_manage_rss_lut(vsi, false); ice_vsi_manage_rss_lut(vsi, false);
if ((features & NETIF_F_HW_VLAN_CTAG_RX) && if ((features & NETIF_F_HW_VLAN_CTAG_RX) &&
!(netdev->features & NETIF_F_HW_VLAN_CTAG_RX)) !(netdev->features & NETIF_F_HW_VLAN_CTAG_RX))