moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gpio: mlxbf2: fix return value check in mlxbf2_gpio_get_lock_res()

Browse Source 
In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200427110829.154785-1-weiyongjun1@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Wei Yongjun
2020-04-27 11:08:29 +00:00
committed by Linus Walleij
parent 1c12857c67
commit 66d8ad67aa
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpio/gpio-mlxbf2.c
View File

@@ -109,8 +109,8 @@ static int mlxbf2_gpio_get_lock_res(struct platform_device *pdev)
} }
yu_arm_gpio_lock_param.io = devm_ioremap(dev, res->start, size); yu_arm_gpio_lock_param.io = devm_ioremap(dev, res->start, size);
if (IS_ERR(yu_arm_gpio_lock_param.io)) if (!yu_arm_gpio_lock_param.io)
ret = PTR_ERR(yu_arm_gpio_lock_param.io); ret = -ENOMEM;
exit: exit:
mutex_unlock(yu_arm_gpio_lock_param.lock); mutex_unlock(yu_arm_gpio_lock_param.lock);