moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

EDAC/altera: Skip defining unused structures for specific configs

Browse Source 
The Altera EDAC driver has several features conditionally built
depending on Kconfig options. The edac_device_prv_data structures
are conditionally used in of_device_id tables. They reference other
functions and structures which can be defined as __maybe_unused.

Silence build warnings like:

  drivers/edac/altera_edac.c:643:37: warning:
      ‘altr_edac_device_inject_fops’ defined but not used [-Wunused-const-variable=]

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
Link: https://lkml.kernel.org/r/20210601092704.203555-1-krzysztof.kozlowski@canonical.com
This commit is contained in:
Krzysztof Kozlowski
2021-06-01 11:27:04 +02:00
committed by Borislav Petkov
parent 767f4b620e
commit 7d07deb3b8
1 changed files with 26 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
drivers/edac/altera_edac.c
View File

@@ -539,10 +539,18 @@ module_platform_driver(altr_edac_driver);
* trigger testing are different for each memory. * trigger testing are different for each memory.
*/ */
#ifdef CONFIG_EDAC_ALTERA_OCRAM
static const struct edac_device_prv_data ocramecc_data; static const struct edac_device_prv_data ocramecc_data;
#endif
#ifdef CONFIG_EDAC_ALTERA_L2C
static const struct edac_device_prv_data l2ecc_data; static const struct edac_device_prv_data l2ecc_data;
#endif
#ifdef CONFIG_EDAC_ALTERA_OCRAM
static const struct edac_device_prv_data a10_ocramecc_data; static const struct edac_device_prv_data a10_ocramecc_data;
#endif
#ifdef CONFIG_EDAC_ALTERA_L2C
static const struct edac_device_prv_data a10_l2ecc_data; static const struct edac_device_prv_data a10_l2ecc_data;
#endif
static irqreturn_t altr_edac_device_handler(int irq, void *dev_id) static irqreturn_t altr_edac_device_handler(int irq, void *dev_id)
{ {
@@ -569,8 +577,8 @@ static irqreturn_t altr_edac_device_handler(int irq, void *dev_id)
return ret_value; return ret_value;
} }
static ssize_t altr_edac_device_trig(struct file *file, static ssize_t __maybe_unused
const char __user *user_buf, altr_edac_device_trig(struct file *file, const char __user *user_buf,
size_t count, loff_t *ppos) size_t count, loff_t *ppos)
{ {
@@ -640,27 +648,27 @@ static ssize_t altr_edac_device_trig(struct file *file,
return count; return count;
} }
static const struct file_operations altr_edac_device_inject_fops = { static const struct file_operations altr_edac_device_inject_fops __maybe_unused = {
.open = simple_open, .open = simple_open,
.write = altr_edac_device_trig, .write = altr_edac_device_trig,
.llseek = generic_file_llseek, .llseek = generic_file_llseek,
}; };
static ssize_t altr_edac_a10_device_trig(struct file *file, static ssize_t __maybe_unused
const char __user *user_buf, altr_edac_a10_device_trig(struct file *file, const char __user *user_buf,
size_t count, loff_t *ppos); size_t count, loff_t *ppos);
static const struct file_operations altr_edac_a10_device_inject_fops = { static const struct file_operations altr_edac_a10_device_inject_fops __maybe_unused = {
.open = simple_open, .open = simple_open,
.write = altr_edac_a10_device_trig, .write = altr_edac_a10_device_trig,
.llseek = generic_file_llseek, .llseek = generic_file_llseek,
}; };
static ssize_t altr_edac_a10_device_trig2(struct file *file, static ssize_t __maybe_unused
const char __user *user_buf, altr_edac_a10_device_trig2(struct file *file, const char __user *user_buf,
size_t count, loff_t *ppos); size_t count, loff_t *ppos);
static const struct file_operations altr_edac_a10_device_inject2_fops = { static const struct file_operations altr_edac_a10_device_inject2_fops __maybe_unused = {
.open = simple_open, .open = simple_open,
.write = altr_edac_a10_device_trig2, .write = altr_edac_a10_device_trig2,
.llseek = generic_file_llseek, .llseek = generic_file_llseek,
@@ -1697,8 +1705,8 @@ MODULE_DEVICE_TABLE(of, altr_edac_a10_device_of_match);
* Based on xgene_edac.c peripheral code. * Based on xgene_edac.c peripheral code.
*/ */
static ssize_t altr_edac_a10_device_trig(struct file *file, static ssize_t __maybe_unused
const char __user *user_buf, altr_edac_a10_device_trig(struct file *file, const char __user *user_buf,
size_t count, loff_t *ppos) size_t count, loff_t *ppos)
{ {
struct edac_device_ctl_info *edac_dci = file->private_data; struct edac_device_ctl_info *edac_dci = file->private_data;
@@ -1729,8 +1737,8 @@ static ssize_t altr_edac_a10_device_trig(struct file *file,
* slightly. A few Arria10 peripherals can use this injection function. * slightly. A few Arria10 peripherals can use this injection function.
* Inject the error into the memory and then readback to trigger the IRQ. * Inject the error into the memory and then readback to trigger the IRQ.
*/ */
static ssize_t altr_edac_a10_device_trig2(struct file *file, static ssize_t __maybe_unused
const char __user *user_buf, altr_edac_a10_device_trig2(struct file *file, const char __user *user_buf,
size_t count, loff_t *ppos) size_t count, loff_t *ppos)
{ {
struct edac_device_ctl_info *edac_dci = file->private_data; struct edac_device_ctl_info *edac_dci = file->private_data;