moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

debugfs: remove return value of debugfs_create_size_t()

Browse Source 
No one checks the return value of debugfs_create_size_t(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20191011132931.1186197-4-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman
2019-10-11 15:29:27 +02:00
parent ad26221fb9
commit 8e5802635f
3 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/filesystems/debugfs.txt
View File

@@ -96,9 +96,8 @@ value to be exported. Some types can have different widths on different
architectures, though, complicating the situation somewhat. There is a architectures, though, complicating the situation somewhat. There is a
function meant to help out in one special case: function meant to help out in one special case:
struct dentry *debugfs_create_size_t(const char *name, umode_t mode, void debugfs_create_size_t(const char *name, umode_t mode,
struct dentry *parent, struct dentry *parent, size_t *value);
size_t *value);
As might be expected, this function will create a debugfs file to represent As might be expected, this function will create a debugfs file to represent
a variable of type size_t. a variable of type size_t.

9
fs/debugfs/file.c
View File

@@ -721,12 +721,11 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_size_t_wo, NULL, debugfs_size_t_set, "%llu\n");
* @value: a pointer to the variable that the file should read to and write * @value: a pointer to the variable that the file should read to and write
* from. * from.
*/ */
struct dentry *debugfs_create_size_t(const char *name, umode_t mode, void debugfs_create_size_t(const char *name, umode_t mode,
struct dentry *parent, size_t *value) struct dentry *parent, size_t *value)
{ {
return debugfs_create_mode_unsafe(name, mode, parent, value, debugfs_create_mode_unsafe(name, mode, parent, value, &fops_size_t,
&fops_size_t, &fops_size_t_ro, &fops_size_t_ro, &fops_size_t_wo);
&fops_size_t_wo);
} }
EXPORT_SYMBOL_GPL(debugfs_create_size_t); EXPORT_SYMBOL_GPL(debugfs_create_size_t);

13
include/linux/debugfs.h
View File

@@ -115,8 +115,8 @@ struct dentry *debugfs_create_x32(const char *name, umode_t mode,
struct dentry *parent, u32 *value); struct dentry *parent, u32 *value);
struct dentry *debugfs_create_x64(const char *name, umode_t mode, struct dentry *debugfs_create_x64(const char *name, umode_t mode,
struct dentry *parent, u64 *value); struct dentry *parent, u64 *value);
struct dentry *debugfs_create_size_t(const char *name, umode_t mode, void debugfs_create_size_t(const char *name, umode_t mode,
struct dentry *parent, size_t *value); struct dentry *parent, size_t *value);
struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode, struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,
struct dentry *parent, atomic_t *value); struct dentry *parent, atomic_t *value);
struct dentry *debugfs_create_bool(const char *name, umode_t mode, struct dentry *debugfs_create_bool(const char *name, umode_t mode,
@@ -296,12 +296,9 @@ static inline struct dentry *debugfs_create_x64(const char *name, umode_t mode,
return ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
} }
static inline struct dentry *debugfs_create_size_t(const char *name, umode_t mode, static inline void debugfs_create_size_t(const char *name, umode_t mode,
struct dentry *parent, struct dentry *parent, size_t *value)
size_t *value) { }
{
return ERR_PTR(-ENODEV);
}
static inline struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode, static inline struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,
struct dentry *parent, atomic_t *value) struct dentry *parent, atomic_t *value)