moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lift rcu_read_lock() into reverse_path_check()

Browse Source 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2020-10-01 14:11:00 -04:00
parent 44cdc1d952
commit b62d2706a7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fs/eventpoll.c
View File

@@ -1257,7 +1257,6 @@ static int reverse_path_check_proc(struct file *file, int depth)
return -1; return -1;
/* CTL_DEL can remove links here, but that can't increase our count */ /* CTL_DEL can remove links here, but that can't increase our count */
rcu_read_lock();
hlist_for_each_entry_rcu(epi, &file->f_ep_links, fllink) { hlist_for_each_entry_rcu(epi, &file->f_ep_links, fllink) {
struct file *recepient = epi->ep->file; struct file *recepient = epi->ep->file;
if (WARN_ON(!is_file_epoll(recepient))) if (WARN_ON(!is_file_epoll(recepient)))
@@ -1269,7 +1268,6 @@ static int reverse_path_check_proc(struct file *file, int depth)
if (error != 0) if (error != 0)
break; break;
} }
rcu_read_unlock();
return error; return error;
} }
@@ -1291,7 +1289,9 @@ static int reverse_path_check(void)
/* let's call this for all tfiles */ /* let's call this for all tfiles */
list_for_each_entry(current_file, &tfile_check_list, f_tfile_llink) { list_for_each_entry(current_file, &tfile_check_list, f_tfile_llink) {
path_count_init(); path_count_init();
rcu_read_lock();
error = reverse_path_check_proc(current_file, 0); error = reverse_path_check_proc(current_file, 0);
rcu_read_unlock();
if (error) if (error)
break; break;
} }