net: mctp: purge receive queues on sk destruction
commit 60bd1d9008a50cc78c4033a16a6f5d78210d481c upstream.
We may have pending skbs in the receive queue when the sk is being
destroyed; add a destructor to purge the queue.
MCTP doesn't use the error queue, so only the receive_queue is purged.
Fixes: 833ef3b91d ("mctp: Populate socket implementation")
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Link: https://lore.kernel.org/r/20230126064551.464468-1-jk@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
046de74f9a
commit
c7caf669b8
@@ -294,6 +294,11 @@ static void mctp_sk_unhash(struct sock *sk)
|
|||||||
synchronize_rcu();
|
synchronize_rcu();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static void mctp_sk_destruct(struct sock *sk)
|
||||||
|
{
|
||||||
|
skb_queue_purge(&sk->sk_receive_queue);
|
||||||
|
}
|
||||||
|
|
||||||
static struct proto mctp_proto = {
|
static struct proto mctp_proto = {
|
||||||
.name = "MCTP",
|
.name = "MCTP",
|
||||||
.owner = THIS_MODULE,
|
.owner = THIS_MODULE,
|
||||||
@@ -330,6 +335,7 @@ static int mctp_pf_create(struct net *net, struct socket *sock,
|
|||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
sock_init_data(sock, sk);
|
sock_init_data(sock, sk);
|
||||||
|
sk->sk_destruct = mctp_sk_destruct;
|
||||||
|
|
||||||
rc = 0;
|
rc = 0;
|
||||||
if (sk->sk_prot->init)
|
if (sk->sk_prot->init)
|
||||||
|
|||||||
Reference in New Issue
Block a user