moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

locks: fix a memory leak bug in __break_lease()

Browse Source 
In __break_lease(), the file lock 'new_fl' is allocated in lease_alloc().
However, it is not deallocated in the following execution if
smp_load_acquire() fails, leading to a memory leak bug. To fix this issue,
free 'new_fl' before returning the error.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
This commit is contained in:
Wenwen Wang
2019-08-19 18:47:34 -05:00
committed by Jeff Layton
parent df2474a22c
commit cfddf9f4c9
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fs/locks.c
View File

@@ -1592,7 +1592,7 @@ int __break_lease(struct inode *inode, unsigned int mode, unsigned int type)
ctx = smp_load_acquire(&inode->i_flctx); ctx = smp_load_acquire(&inode->i_flctx);
if (!ctx) { if (!ctx) {
WARN_ON_ONCE(1); WARN_ON_ONCE(1);
return error; goto free_lock;
} }
percpu_down_read(&file_rwsem); percpu_down_read(&file_rwsem);
@@ -1672,6 +1672,7 @@ out:
spin_unlock(&ctx->flc_lock); spin_unlock(&ctx->flc_lock);
percpu_up_read(&file_rwsem); percpu_up_read(&file_rwsem);
locks_dispose_list(&dispose); locks_dispose_list(&dispose);
free_lock:
locks_free_lock(new_fl); locks_free_lock(new_fl);
return error; return error;
} }