mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
This change converts the existing mmap_sem rwsem calls to use the new mmap locking API instead. The change is generated using coccinelle with the following rule: // spatch --sp-file mmap_lock_api.cocci --in-place --include-headers --dir . @@ expression mm; @@ ( -init_rwsem +mmap_init_lock | -down_write +mmap_write_lock | -down_write_killable +mmap_write_lock_killable | -down_write_trylock +mmap_write_trylock | -up_write +mmap_write_unlock | -downgrade_write +mmap_write_downgrade | -down_read +mmap_read_lock | -down_read_killable +mmap_read_lock_killable | -down_read_trylock +mmap_read_trylock | -up_read +mmap_read_unlock ) -(&mm->mmap_sem) +(mm) Signed-off-by: Michel Lespinasse <walken@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com> Reviewed-by: Laurent Dufour <ldufour@linux.ibm.com> Reviewed-by: Vlastimil Babka <vbabka@suse.cz> Cc: Davidlohr Bueso <dbueso@suse.de> Cc: David Rientjes <rientjes@google.com> Cc: Hugh Dickins <hughd@google.com> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: Jerome Glisse <jglisse@redhat.com> Cc: John Hubbard <jhubbard@nvidia.com> Cc: Liam Howlett <Liam.Howlett@oracle.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ying Han <yinghan@google.com> Link: http://lkml.kernel.org/r/20200520052908.204642-5-walken@google.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
committed by
Linus Torvalds
parent
0adf65f53a
commit
d8ed45c5dc
@@ -228,7 +228,7 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm,
|
||||
* feature is not supported.
|
||||
*/
|
||||
if (zeropage) {
|
||||
up_read(&dst_mm->mmap_sem);
|
||||
mmap_read_unlock(dst_mm);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
@@ -315,7 +315,7 @@ retry:
|
||||
cond_resched();
|
||||
|
||||
if (unlikely(err == -ENOENT)) {
|
||||
up_read(&dst_mm->mmap_sem);
|
||||
mmap_read_unlock(dst_mm);
|
||||
BUG_ON(!page);
|
||||
|
||||
err = copy_huge_page_from_user(page,
|
||||
@@ -326,7 +326,7 @@ retry:
|
||||
err = -EFAULT;
|
||||
goto out;
|
||||
}
|
||||
down_read(&dst_mm->mmap_sem);
|
||||
mmap_read_lock(dst_mm);
|
||||
|
||||
dst_vma = NULL;
|
||||
goto retry;
|
||||
@@ -346,7 +346,7 @@ retry:
|
||||
}
|
||||
|
||||
out_unlock:
|
||||
up_read(&dst_mm->mmap_sem);
|
||||
mmap_read_unlock(dst_mm);
|
||||
out:
|
||||
if (page) {
|
||||
/*
|
||||
@@ -485,7 +485,7 @@ static __always_inline ssize_t __mcopy_atomic(struct mm_struct *dst_mm,
|
||||
copied = 0;
|
||||
page = NULL;
|
||||
retry:
|
||||
down_read(&dst_mm->mmap_sem);
|
||||
mmap_read_lock(dst_mm);
|
||||
|
||||
/*
|
||||
* If memory mappings are changing because of non-cooperative
|
||||
@@ -583,7 +583,7 @@ retry:
|
||||
if (unlikely(err == -ENOENT)) {
|
||||
void *page_kaddr;
|
||||
|
||||
up_read(&dst_mm->mmap_sem);
|
||||
mmap_read_unlock(dst_mm);
|
||||
BUG_ON(!page);
|
||||
|
||||
page_kaddr = kmap(page);
|
||||
@@ -612,7 +612,7 @@ retry:
|
||||
}
|
||||
|
||||
out_unlock:
|
||||
up_read(&dst_mm->mmap_sem);
|
||||
mmap_read_unlock(dst_mm);
|
||||
out:
|
||||
if (page)
|
||||
put_page(page);
|
||||
@@ -652,7 +652,7 @@ int mwriteprotect_range(struct mm_struct *dst_mm, unsigned long start,
|
||||
/* Does the address range wrap, or is the span zero-sized? */
|
||||
BUG_ON(start + len <= start);
|
||||
|
||||
down_read(&dst_mm->mmap_sem);
|
||||
mmap_read_lock(dst_mm);
|
||||
|
||||
/*
|
||||
* If memory mappings are changing because of non-cooperative
|
||||
@@ -686,6 +686,6 @@ int mwriteprotect_range(struct mm_struct *dst_mm, unsigned long start,
|
||||
|
||||
err = 0;
|
||||
out_unlock:
|
||||
up_read(&dst_mm->mmap_sem);
|
||||
mmap_read_unlock(dst_mm);
|
||||
return err;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user