moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tools: gpio: fix spurious close warning in gpio-utils

Browse Source 
Fix bogus close warning that occurs when opening the character device
fails.

Signed-off-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
This commit is contained in:
Kent Gibson
2020-07-08 12:15:59 +08:00
committed by Bartosz Golaszewski
parent ef3c61a082
commit e890678f69
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/gpio/gpio-utils.c
View File

@@ -75,7 +75,7 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines,
ret = -errno; ret = -errno;
fprintf(stderr, "Failed to open %s, %s\n", fprintf(stderr, "Failed to open %s, %s\n",
chrdev_name, strerror(errno)); chrdev_name, strerror(errno));
goto exit_close_error; goto exit_free_name;
} }
for (i = 0; i < nlines; i++) for (i = 0; i < nlines; i++)
@@ -94,9 +94,9 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines,
"GPIO_GET_LINEHANDLE_IOCTL", ret, strerror(errno)); "GPIO_GET_LINEHANDLE_IOCTL", ret, strerror(errno));
} }
exit_close_error:
if (close(fd) == -1) if (close(fd) == -1)
perror("Failed to close GPIO character device file"); perror("Failed to close GPIO character device file");
exit_free_name:
free(chrdev_name); free(chrdev_name);
return ret < 0 ? ret : req.fd; return ret < 0 ? ret : req.fd;
} }