moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Input: omap4-keypad - fix pm_runtime_get_sync() error checking

Browse Source 
[ Upstream commit 81022a170462d38ea10612cb67e8e2c529d58abe ]

If the device is already in a runtime PM enabled state
pm_runtime_get_sync() will return 1, so a test for negative
value should be used to check for errors.

Fixes: f77621cc64 ("Input: omap-keypad - dynamically handle register offsets")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220412070131.19848-1-linmq006@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Miaoqian Lin
2022-04-17 13:03:31 -07:00
committed by Greg Kroah-Hartman
parent 232541989a
commit f0cfae3e0d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/input/keyboard/omap4-keypad.c
View File

@@ -393,7 +393,7 @@ static int omap4_keypad_probe(struct platform_device *pdev)
* revision register. * revision register.
*/ */
error = pm_runtime_get_sync(dev); error = pm_runtime_get_sync(dev);
if (error) { if (error < 0) {
dev_err(dev, "pm_runtime_get_sync() failed\n"); dev_err(dev, "pm_runtime_get_sync() failed\n");
pm_runtime_put_noidle(dev); pm_runtime_put_noidle(dev);
return error; return error;