To avoid changing the visibiliy of data types when including
hook definition headers remove header file inclusions from
the hook definition header files.
Instead, the hook definition headers should just have forward
declarations that don't require full definition.
To provide full definitions of the types for the KMI, the
headers that define the types should be included by the
source file that instantiates the hooks - normally
vendor_hooks.c.
Bug: 233047575
Signed-off-by: Todd Kjos <tkjos@google.com>
Change-Id: Iaaa1a6f45a356569c04ad2fea0b1514e0454f041
This change is intended to reduce the chance of a missed ABI break
involving vendor hooks.
The following types are now fully defined in ABI XML.
* `struct binder_transaction`
* `struct binder_thread`
* `struct binder_proc`
* `struct printk_ringbuffer`
* `struct printk_record`
symbol '__alloc_pages' changed
CRC changed from 0x6497cbd to 0x230fd8e5
symbol '__find_vma' changed
CRC changed from 0xf11b619f to 0xb0069a61
symbol '__free_pages' changed
CRC changed from 0xba5eeb68 to 0xdc394265
... 195 omitted; 198 symbols have only CRC changes
Bug: 233047575
Change-Id: I807227f6161f0a44ec3657dc8cdb8a3fdffc40b3
Signed-off-by: Giuliano Procida <gprocida@google.com>
When vendor hooks are added to a file that previously didn't have any
vendor hooks, we end up indirectly including linux/tracepoint.h. This
causes some data types that used to be opaque (forward declared) to the
code to become visible to the code.
Modversions correctly catches this change in visibility, but we don't
really care about the data types made visible when linux/tracepoint.h is
included. So, hide this from modversions in the central vendor_hooks.h file
instead of having to fix this on a case by case basis.
This change itself will cause a one time CRC breakage/churn because it's
fixing the existing vendor hook headers, but should reduce unnecessary CRC
churns in the future.
To avoid future pointless CRC churn, vendor hook header files that include
vendor_hooks.h should not include linux/tracepoint.h directly.
Bug: 227513263
Bug: 226140073
Signed-off-by: Saravana Kannan <saravanak@google.com>
Change-Id: Ia88e6af11dd94fe475c464eb30a6e5e1e24c938b
commit 0820d8e399 ("ANDROID: logbuf: Add new logbuf vendor hook to support pr_cont()")
added a vendor hook, but broke kernelci builds with
!CONFIG_ANDROID_VENDOR_HOOKS.
The fix is to remove the old "#if defined(CONFIG_ANDROID_VENDOR_HOOKS)"
guard that is now obsolete.
Fixes: 0820d8e399 ("ANDROID: logbuf: Add new logbuf vendor hook to support pr_cont()")
Signed-off-by: Todd Kjos <tkjos@google.com>
Change-Id: I60932d17f3d5019e25d0d767e8a88ded877267de
Initial kernel bootup logs get overwritten after running
for a long time, and there can be debugging scenario where
we need initial ~100s bootup logs for debugging.
'android_vh_initial_logbuf' vendor hook is helping in
achieving this purpose.
Bug: 199236943
Change-Id: I706824aeb566c09ecaf4b5900973d6cee8a2f35b
Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
(cherry picked from commit 34fde61f72)
Signed-off-by: Yogesh Lal <ylal@codeaurora.org>
