moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
0dc1663e3fc22c72e1ab33be7701a0d51cca84ef
kernel_arpi/kernel
History
Chen Zhongjin f0c151602f profiling: fix shift too large makes kernel panic 
[ Upstream commit 0fe6ee8f123a4dfb529a5aff07536bb481f34043 ]

2d186afd04 ("profiling: fix shift-out-of-bounds bugs") limits shift
value by [0, BITS_PER_LONG -1], which means [0, 63].

However, syzbot found that the max shift value should be the bit number of
(_etext - _stext).  If shift is outside of this, the "buffer_bytes" will
be zero and will cause kzalloc(0).  Then the kernel panics due to
dereferencing the returned pointer 16.

This can be easily reproduced by passing a large number like 60 to enable
profiling and then run readprofile.

LOGS:
 BUG: kernel NULL pointer dereference, address: 0000000000000010
 #PF: supervisor write access in kernel mode
 #PF: error_code(0x0002) - not-present page
 PGD 6148067 P4D 6148067 PUD 6142067 PMD 0
 PREEMPT SMP
 CPU: 4 PID: 184 Comm: readprofile Not tainted 5.18.0+ #162
 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.15.0-0-g2dd4b9b3f840-prebuilt.qemu.org 04/01/2014
 RIP: 0010:read_profile+0x104/0x220
 RSP: 0018:ffffc900006fbe80 EFLAGS: 00000202
 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
 RDX: ffff888006150000 RSI: 0000000000000001 RDI: ffffffff82aba4a0
 RBP: 000000000188bb60 R08: 0000000000000010 R09: ffff888006151000
 R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff82aba4a0
 R13: 0000000000000000 R14: ffffc900006fbf08 R15: 0000000000020c30
 FS:  000000000188a8c0(0000) GS:ffff88803ed00000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 0000000000000010 CR3: 0000000006144000 CR4: 00000000000006e0
 Call Trace:
  <TASK>
  proc_reg_read+0x56/0x70
  vfs_read+0x9a/0x1b0
  ksys_read+0xa1/0xe0
  ? fpregs_assert_state_consistent+0x1e/0x40
  do_syscall_64+0x3a/0x80
  entry_SYSCALL_64_after_hwframe+0x46/0xb0
 RIP: 0033:0x4d4b4e
 RSP: 002b:00007ffebb668d58 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
 RAX: ffffffffffffffda RBX: 000000000188a8a0 RCX: 00000000004d4b4e
 RDX: 0000000000000400 RSI: 000000000188bb60 RDI: 0000000000000003
 RBP: 0000000000000003 R08: 000000000000006e R09: 0000000000000000
 R10: 0000000000000041 R11: 0000000000000246 R12: 000000000188bb60
 R13: 0000000000000400 R14: 0000000000000000 R15: 000000000188bb60
  </TASK>
 Modules linked in:
 CR2: 0000000000000010
Killed
 ---[ end trace 0000000000000000 ]---

Check prof_len in profile_init() to prevent it be zero.

Link: https://lkml.kernel.org/r/20220531012854.229439-1-chenzhongjin@huawei.com
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-08-17 14:24:04 +02:00
..
bpf
bpf: Fix subprog names in stack traces.
2022-08-17 14:23:30 +02:00
cgroup
cgroup: Use separate src/dst nodes when preloading css_sets for migration
2022-07-21 21:24:13 +02:00
configs
…
debug
lockdown: also lock down previous kgdb use
2022-05-25 09:57:37 +02:00
dma
dma-direct: use the correct size for dma_set_encrypted()
2022-06-29 09:03:31 +02:00
entry
signal: Replace force_fatal_sig with force_exit_sig when in doubt
2021-11-25 09:49:07 +01:00
events
perf/core: Fix data race between perf_event_set_output() and perf_mmap_close()
2022-07-29 17:25:11 +02:00
gcov
…
irq
irqdomain: Report irq number for NOMAP domains
2022-08-17 14:23:14 +02:00
kcsan
Merge tag 'locking-debug-2021-09-01' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2021-09-02 13:00:15 -07:00
livepatch
livepatch: Fix build failure on 32 bits processors
2022-04-08 14:23:29 +02:00
locking
locking/lockdep: Fix lockdep_init_map_*() confusion
2022-08-17 14:23:08 +02:00
power
PM: hibernate: defer device probing when resuming from hibernation
2022-08-17 14:23:04 +02:00
printk
printk: wake waiters for safe and NMI contexts
2022-06-09 10:22:49 +02:00
rcu
rcutorture: Fix ksoftirqd boosting timing and iteration
2022-08-17 14:23:23 +02:00
sched
nohz/full, sched/rt: Fix missed tick-reenabling bug in dequeue_task_rt()
2022-08-17 14:23:14 +02:00
time
wireguard: ratelimiter: use hrtimer in selftest
2022-08-17 14:23:37 +02:00
trace
blktrace: Trace remapped requests correctly
2022-08-17 14:23:13 +02:00
.gitignore
…
acct.c
kernel/acct.c: use dedicated helper to access rlimit values
2021-09-08 11:50:26 -07:00
async.c
Revert "module, async: async_synchronize_full() on module init iff async is used"
2022-02-23 12:03:07 +01:00
audit_fsnotify.c
…
audit_tree.c
…
audit_watch.c
…
audit.c
audit: improve audit queue handling when "audit=1" on cmdline
2022-02-08 18:34:03 +01:00
audit.h
audit: log AUDIT_TIME_* records only from rules
2022-04-08 14:23:06 +02:00
auditfilter.c
…
auditsc.c
audit: log AUDIT_TIME_* records only from rules
2022-04-08 14:23:06 +02:00
backtracetest.c
…
bounds.c
…
capability.c
…
cfi.c
cfi: Fix __cfi_slowpath_diag RCU usage with cpuidle
2022-06-22 14:22:04 +02:00
compat.c
arch: remove compat_alloc_user_space
2021-09-08 15:32:35 -07:00
configs.c
…
context_tracking.c
…
cpu_pm.c
…
cpu.c
random: clear fast pool, crng, and batches in cpuhp bring up
2022-05-30 09:29:09 +02:00
crash_core.c
kernel/crash_core: suppress unknown crashkernel parameter warning
2021-12-29 12:28:49 +01:00
crash_dump.c
…
cred.c
ucounts: Base set_cred_ucounts changes on the real user
2022-02-23 12:03:20 +01:00
delayacct.c
…
dma.c
…
exec_domain.c
…
exit.c
fix race between exit_itimers() and /proc/pid/timers
2022-07-21 21:24:11 +02:00
extable.c
…
fail_function.c
…
fork.c
sched: Fix yet more sched_fork() races
2022-03-08 19:12:49 +01:00
freezer.c
…
futex.c
futex: Remove unused variable 'vpid' in futex_proxy_trylock_atomic()
2021-09-03 23:00:22 +02:00
gen_kheaders.sh
…
groups.c
…
hung_task.c
…
iomem.c
…
irq_work.c
…
jump_label.c
…
kallsyms.c
…
kcmp.c
…
Kconfig.freezer
…
Kconfig.hz
…
Kconfig.locks
…
Kconfig.preempt
…
kcov.c
…
kexec_core.c
…
kexec_elf.c
…
kexec_file.c
ima: force signature verification when CONFIG_KEXEC_SIG is configured
2022-07-21 21:24:29 +02:00
kexec_internal.h
…
kexec.c
kexec: avoid compat_alloc_user_space
2021-09-08 15:32:34 -07:00
kheaders.c
…
kmod.c
…
kprobes.c
kprobes: Limit max data_size of the kretprobe instances
2021-12-08 09:04:41 +01:00
ksysfs.c
…
kthread.c
…
latencytop.c
…
Makefile
static_call: Don't make __static_call_return0 static
2022-04-13 20:59:28 +02:00
module_signature.c
…
module_signing.c
…
module-internal.h
…
module.c
module: fix [e_shstrndx].sh_size=0 OOB access
2022-07-12 16:35:09 +02:00
notifier.c
…
nsproxy.c
memcg: enable accounting for new namesapces and struct nsproxy
2021-09-03 09:58:12 -07:00
padata.c
…
panic.c
…
params.c
…
pid_namespace.c
memcg: enable accounting for new namesapces and struct nsproxy
2021-09-03 09:58:12 -07:00
pid.c
…
profile.c
profiling: fix shift too large makes kernel panic
2022-08-17 14:24:04 +02:00
ptrace.c
ptrace: Reimplement PTRACE_KILL by always sending SIGKILL
2022-06-09 10:22:29 +02:00
range.c
…
reboot.c
…
regset.c
…
relay.c
…
resource_kunit.c
…
resource.c
kernel/resource: fix kfree() of bootmem memory again
2022-04-08 14:23:43 +02:00
rseq.c
rseq: Remove broken uapi field layout on 32-bit little endian
2022-04-08 14:23:10 +02:00
scftorture.c
scftorture: Fix distribution of short handler delays
2022-06-09 10:22:46 +02:00
scs.c
scs: Release kasan vmalloc poison in scs_free process
2021-11-18 19:16:29 +01:00
seccomp.c
seccomp: Invalidate seccomp mode to catch death failures
2022-02-16 12:56:38 +01:00
signal.c
signal handling: don't use BUG_ON() for debugging
2022-07-21 21:24:42 +02:00
smp.c
smp: Fix offline cpu check in flush_smp_call_function_queue()
2022-04-20 09:34:21 +02:00
smpboot.c
…
smpboot.h
…
softirq.c
…
stackleak.c
gcc-plugins/stackleak: Use noinstr in favor of notrace
2022-02-23 12:03:07 +01:00
stacktrace.c
stacktrace: move filter_irq_stacks() to kernel/stacktrace.c
2022-04-13 20:59:28 +02:00
static_call_inline.c
static_call: Don't make __static_call_return0 static
2022-04-13 20:59:28 +02:00
static_call.c
static_call: Don't make __static_call_return0 static
2022-04-13 20:59:28 +02:00
stop_machine.c
…
sys_ni.c
compat: remove some compat entry points
2021-09-08 15:32:35 -07:00
sys.c
ucounts: Move RLIMIT_NPROC handling after set_user
2022-02-23 12:03:20 +01:00
sysctl-test.c
…
sysctl.c
sysctl: move some boundary constants from sysctl.c to sysctl_vals
2022-07-29 17:25:11 +02:00
task_work.c
…
taskstats.c
…
test_kprobes.c
…
torture.c
…
tracepoint.c
…
tsacct.c
taskstats: Cleanup the use of task->exit_code
2022-01-27 11:05:35 +01:00
ucount.c
ucounts: Handle wrapping in is_ucounts_overlimit
2022-02-23 12:03:20 +01:00
uid16.c
…
uid16.h
…
umh.c
…
up.c
…
user_namespace.c
ucounts: Fix systemd LimitNPROC with private users regression
2022-03-08 19:12:42 +01:00
user-return-notifier.c
…
user.c
fs/epoll: use a per-cpu counter for user's watches count
2021-09-08 11:50:27 -07:00
usermode_driver.c
…
utsname_sysctl.c
…
utsname.c
…
watch_queue.c
watch_queue: Fix missing locking in add_watch_to_object()
2022-08-03 12:03:43 +02:00
watchdog_hld.c
…
watchdog.c
…
workqueue_internal.h
…
workqueue.c
workqueue: Fix unbind_workers() VS wq_worker_running() race
2022-01-16 09:12:41 +01:00