Martin KaFai Lau 4e3264d21b
bpf: Fix bpf_redirect to an ipip/ip6tnl dev ...
If the bpf program calls bpf_redirect(dev, 0) and dev is
an ipip/ip6tnl, it currently includes the mac header.
e.g. If dev is ipip, the end result is IP-EthHdr-IP instead
of IP-IP.
The fix is to pull the mac header. At ingress, skb_postpull_rcsum()
is not needed because the ethhdr should have been pulled once already
and then got pushed back just before calling the bpf_prog.
At egress, this patch calls skb_postpull_rcsum().
If bpf_redirect(dev, BPF_F_INGRESS) is called,
it also fails now because it calls dev_forward_skb() which
eventually calls eth_type_trans(skb, dev). The eth_type_trans()
will set skb->type = PACKET_OTHERHOST because the mac address
does not match the redirecting dev->dev_addr. The PACKET_OTHERHOST
will eventually cause the ip_rcv() errors out. To fix this,
____dev_forward_skb() is added.
Joint work with Daniel Borkmann.
Fixes: cfc7381b308d79266bc4daniel@iogearbox.net >
Acked-by: Alexei Starovoitov <ast@fb.com >
Signed-off-by: Martin KaFai Lau <kafai@fb.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2016-11-12 23:38:07 -05:00
2016-10-12 11:01:37 -07:00
2016-10-05 10:11:24 -07:00
2016-09-22 10:01:21 +02:00
2016-10-03 16:13:50 +02:00
2016-09-15 21:15:40 +05:30
2016-09-10 16:48:46 +05:30
2016-09-01 14:23:39 -07:00
2016-10-11 15:06:33 -07:00
2016-09-14 20:42:03 +02:00
2016-10-17 16:26:29 +01:00
2016-10-07 08:35:35 -07:00
2016-10-29 16:23:48 -04:00
2016-10-29 12:00:39 -04:00
2016-10-05 11:34:53 -07:00
2016-10-08 20:56:54 -07:00
2016-09-12 19:59:39 +02:00
2016-10-03 19:43:08 -07:00
2016-09-10 17:31:39 +05:30
2016-10-11 13:22:22 -07:00
2016-09-21 02:08:04 +02:00
2016-10-22 17:08:07 -04:00
2016-10-07 09:45:43 -07:00
2016-09-30 09:13:58 -07:00
2016-08-23 15:46:33 -05:00
2016-09-30 09:14:10 -07:00
2016-10-13 21:28:20 -07:00
2016-09-14 20:37:50 +02:00
2016-08-31 10:06:03 +03:00
2016-09-12 20:32:40 +01:00
2016-10-24 14:18:14 +02:00
2016-09-20 14:35:59 -05:00
2016-09-05 12:41:46 +02:00
2016-08-25 11:26:48 -04:00
2016-09-27 12:54:03 +02:00
2016-10-11 15:06:31 -07:00
2016-10-11 15:06:31 -07:00
2016-09-22 07:48:03 -06:00
2016-09-09 12:09:24 +03:00
2016-08-18 10:44:20 +02:00
2016-10-07 18:46:26 -07:00
2016-09-14 09:18:06 -06:00
2016-10-14 12:18:50 -07:00
2016-09-15 08:42:03 -06:00
2016-10-09 17:32:20 -07:00
2016-09-14 11:48:34 -06:00
2016-09-15 18:29:06 -04:00
2016-10-07 18:46:28 -07:00
2016-09-29 01:35:35 -04:00
2016-09-29 01:35:35 -04:00
2016-09-09 12:09:24 +03:00
2016-08-11 09:41:35 -06:00
2016-08-09 18:47:16 +08:00
2016-08-22 14:05:49 -03:00
2016-08-22 14:00:51 -03:00
2016-10-14 12:18:50 -07:00
2016-10-17 15:27:27 -07:00
2016-10-07 18:46:29 -07:00
2016-09-27 21:20:53 -04:00
2016-10-10 14:51:45 -07:00
2016-10-15 10:03:15 -07:00
2016-10-07 18:46:30 -07:00
2016-08-31 13:05:43 +02:00
2016-10-07 18:46:30 -07:00
2016-10-20 16:35:50 +02:00
2016-10-20 20:10:17 +02:00
2016-10-07 18:46:30 -07:00
2016-10-11 15:06:30 -07:00
2016-09-19 11:24:50 +10:00
2016-09-16 12:44:20 +02:00
2016-09-21 12:13:31 +02:00
2016-09-06 13:08:40 +09:00
2016-09-14 13:56:38 -04:00
2016-09-16 09:34:15 +01:00
2016-09-26 22:16:41 +05:30
2016-09-16 09:34:22 +01:00
2016-10-11 15:06:32 -07:00
2016-09-13 20:21:55 +02:00
2016-10-14 14:26:58 -07:00
2016-10-06 09:07:44 -04:00
2016-09-16 08:53:41 +02:00
2016-09-30 10:05:46 -07:00
2016-10-03 09:11:14 -07:00
2016-10-15 10:03:15 -07:00
2016-08-11 15:33:23 +05:30
2016-08-21 17:43:32 +02:00
2016-09-09 19:36:04 -07:00
2016-10-14 17:23:33 -07:00
2016-10-07 15:15:33 -07:00
2016-10-07 18:46:26 -07:00
2016-09-16 12:44:20 +02:00
2016-09-02 12:47:55 -04:00
2016-10-06 11:48:41 -07:00
2016-10-10 14:51:45 -07:00
2016-08-21 20:12:32 +01:00
2016-09-29 10:40:13 +02:00
2016-08-24 15:58:57 +02:00
2016-10-07 18:46:28 -07:00
2016-10-07 18:46:29 -07:00
2016-08-24 21:04:48 +08:00
2016-09-08 21:34:15 -07:00
2016-10-29 15:03:14 -04:00
2016-09-05 13:52:38 +02:00
2016-08-25 22:11:02 +02:00
2016-09-24 10:48:18 +02:00
2016-09-01 22:48:33 -07:00
2016-09-24 08:01:26 -04:00
2016-10-07 23:50:39 -04:00
2016-09-08 17:10:28 -07:00
2016-09-08 16:13:09 -07:00
2016-09-16 09:18:54 +02:00
2016-10-15 10:03:15 -07:00
2016-09-14 22:11:09 +02:00
2016-08-24 09:43:49 +02:00
2016-10-26 15:45:38 +10:00
2016-10-20 15:51:28 +11:00
2016-09-16 09:34:15 +01:00
2016-09-14 09:18:09 -06:00
2016-11-03 16:05:44 -04:00
2016-09-20 23:20:32 +02:00
2016-09-14 15:28:15 +02:00
2016-10-07 18:46:26 -07:00
2016-10-03 13:22:39 -07:00
2016-10-16 11:02:31 +02:00
2016-10-27 18:43:43 -07:00
2016-10-09 12:23:38 -07:00
2016-10-07 18:46:30 -07:00
2016-08-10 11:23:44 -04:00
2016-10-11 15:06:33 -07:00
2016-10-11 15:06:33 -07:00
2016-10-11 15:06:33 -07:00
2016-10-05 10:11:24 -07:00
2016-09-16 16:57:47 +02:00
2016-09-15 16:49:39 +02:00
2016-09-22 11:50:29 -04:00
2016-09-30 19:13:42 -07:00
2016-09-21 07:57:31 -06:00
2016-09-14 12:57:43 -07:00
2016-08-18 23:41:55 +02:00
2016-09-24 10:48:32 +02:00
2016-09-19 13:42:38 -04:00
2016-09-19 12:27:10 +10:00
2016-09-15 21:13:50 +05:30
2016-09-27 12:33:47 +02:00
2016-10-07 18:46:28 -07:00
2016-10-07 18:46:29 -07:00
2016-09-01 17:52:01 -07:00
2016-08-31 14:12:35 +02:00
2016-10-07 18:46:27 -07:00
2016-10-24 19:13:20 -07:00
2016-10-27 09:27:57 -07:00
2016-09-30 12:46:48 -05:00
2016-09-25 23:41:39 -04:00
2016-09-25 23:41:39 -04:00
2016-09-14 22:11:08 +02:00
2016-10-07 09:20:53 -07:00
2016-08-28 23:32:41 -04:00
2016-11-12 23:38:07 -05:00
2016-09-25 14:38:48 +02:00
2016-09-25 23:34:19 +02:00
2016-09-27 14:34:01 -04:00
2016-09-22 15:54:27 -04:00
2016-09-19 13:11:13 -04:00
2016-10-07 18:46:30 -07:00
2016-10-19 11:36:22 -06:00
2016-09-28 17:43:15 +02:00
2016-10-03 23:38:11 +02:00
2016-09-16 09:34:14 +01:00
2016-09-15 08:33:01 -05:00
2016-09-28 08:53:14 +05:30
2016-08-29 11:00:23 +03:00
2016-10-07 18:46:28 -07:00
2016-09-19 21:44:30 +02:00
2016-10-07 18:46:27 -07:00
2016-10-07 18:46:27 -07:00
2016-10-11 15:06:34 -07:00
2016-10-07 11:46:37 -07:00
2016-09-22 15:25:54 +02:00
2016-10-28 11:06:25 +02:00
2016-09-22 08:21:21 -04:00
2016-10-05 18:24:00 -04:00
2016-10-14 11:36:59 -07:00
2016-09-13 02:49:34 +02:00
2016-09-27 21:52:00 -04:00
2016-10-08 11:06:08 -04:00
2016-10-09 12:23:38 -07:00
2016-09-22 19:59:41 -05:00
2016-09-30 15:26:52 -07:00
2016-09-08 15:01:10 -07:00
2016-09-08 15:01:10 -07:00
2016-09-22 02:18:33 -04:00
2016-09-05 16:45:39 +02:00
2016-09-12 20:01:43 +01:00
2016-10-11 15:06:30 -07:00
2016-10-15 10:03:15 -07:00
2016-08-18 15:36:59 +02:00
2016-08-22 09:36:57 -07:00
2016-09-16 12:06:24 +01:00
2016-10-11 15:06:32 -07:00
2016-10-02 22:50:21 -07:00
2016-09-20 04:43:36 -04:00
2016-09-08 22:15:25 -07:00
2016-09-01 16:56:15 -07:00
2016-09-17 08:39:12 -06:00
2016-10-07 18:46:28 -07:00
2016-09-19 12:27:10 +10:00
2016-10-11 15:06:33 -07:00
2016-10-07 18:46:30 -07:00
2016-08-31 15:36:01 +02:00
2016-09-28 17:46:46 +02:00
2016-10-26 17:31:23 -04:00
2016-09-06 18:30:20 +02:00
2016-08-28 23:44:55 -04:00
2016-09-05 13:52:39 +02:00
2016-10-05 18:23:36 -04:00
2016-09-13 02:17:19 +02:00
2016-10-07 18:46:27 -07:00
2016-08-11 15:39:38 +05:30
2016-10-17 09:50:56 -07:00
2016-10-06 09:52:23 -07:00
2016-09-15 09:51:14 -04:00
2016-09-21 00:23:00 -04:00
2016-09-27 14:35:21 +08:00
2016-10-20 13:27:47 +02:00
2016-08-31 14:43:35 -07:00
2016-09-22 17:02:55 +02:00
2016-08-22 10:10:12 -07:00
2016-09-30 11:46:40 +02:00
2016-08-08 13:02:01 -07:00
2016-10-10 13:38:49 -07:00
2016-09-13 08:08:24 +02:00
2016-09-22 20:00:36 -05:00
2016-08-16 18:49:56 +02:00
2016-08-31 13:20:15 +02:00
2016-09-30 10:54:03 +02:00
2016-10-08 10:27:10 +02:00
2016-09-21 00:22:59 -04:00
2016-08-29 08:13:21 -06:00
2016-10-07 18:46:27 -07:00
2016-10-07 21:48:36 -04:00
4e3264d21b