moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
2274a7421e732b9be095029537062cc00a54c19a
kernel_arpi/kernel/trace
History
Vamshi K Sthambamkadi f4748ee4fa tracing/probe: Fix memleak in fetch_op_data operations 
commit 3aa8fdc37d upstream.

kmemleak report:
    [<57dcc2ca>] __kmalloc_track_caller+0x139/0x2b0
    [<f1c45d0f>] kstrndup+0x37/0x80
    [<f9761eb0>] parse_probe_arg.isra.7+0x3cc/0x630
    [<055bf2ba>] traceprobe_parse_probe_arg+0x2f5/0x810
    [<655a7766>] trace_kprobe_create+0x2ca/0x950
    [<4fc6a02a>] create_or_delete_trace_kprobe+0xf/0x30
    [<6d1c8a52>] trace_run_command+0x67/0x80
    [<be812cc0>] trace_parse_run_command+0xa7/0x140
    [<aecfe401>] probes_write+0x10/0x20
    [<2027641c>] __vfs_write+0x30/0x1e0
    [<6a4aeee1>] vfs_write+0x96/0x1b0
    [<3517fb7d>] ksys_write+0x53/0xc0
    [<dad91db7>] __ia32_sys_write+0x15/0x20
    [<da347f64>] do_syscall_32_irqs_on+0x3d/0x260
    [<fd0b7e7d>] do_fast_syscall_32+0x39/0xb0
    [<ea5ae810>] entry_SYSENTER_32+0xaf/0x102

Post parse_probe_arg(), the FETCH_OP_DATA operation type is overwritten
to FETCH_OP_ST_STRING, as a result memory is never freed since
traceprobe_free_probe_arg() iterates only over SYMBOL and DATA op types

Setup fetch string operation correctly after fetch_op_data operation.

Link: https://lkml.kernel.org/r/20200615143034.GA1734@cosmos

Cc: stable@vger.kernel.org
Fixes: a42e3c4de9 ("tracing/probe: Add immediate string parameter support")
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-06-24 17:50:51 +02:00
..
blktrace.c
blktrace: fix endianness for blk_log_remap()
2020-06-24 17:50:39 +02:00
bpf_trace.c
bpf: Fix deadlock with rq_lock in bpf_send_signal()
2020-04-17 10:49:57 +02:00
fgraph.c
ftrace: Look up the address of return_to_handler() using helpers
2019-09-18 12:24:47 +10:00
ftrace_internal.h
treewide: Rename rcu_dereference_raw_notrace() to _check()
2019-08-01 14:16:21 -07:00
ftrace.c
ftrace: fpid_next() should increase position index
2020-02-24 08:36:59 +01:00
Kconfig
Stop the ad-hoc games with -Wno-maybe-initialized
2020-05-20 08:20:28 +02:00
Makefile
…
power-traces.c
…
preemptirq_delay_test.c
…
ring_buffer_benchmark.c
tracing: Use CONFIG_PREEMPTION
2019-07-31 19:03:35 +02:00
ring_buffer.c
tracing: Do not create directories if lockdown is in affect
2020-01-12 12:21:45 +01:00
rpm-traces.c
…
trace_benchmark.c
…
trace_benchmark.h
…
trace_branch.c
x86/uaccess, ftrace: Fix ftrace_likely_update() vs. SMAP
2019-04-03 11:02:24 +02:00
trace_clock.c
…
trace_dynevent.c
tracing: Add tracing_check_open_get_tr()
2019-10-12 20:44:07 -04:00
trace_dynevent.h
tracing/dynevent: Pass extra arguments to match operation
2019-08-31 12:19:38 -04:00
trace_entries.h
tracing: Change the function format to display function names by perf
2019-02-11 14:53:43 -05:00
trace_event_perf.c
tracing: Fix race in perf_trace_buf initialization
2019-10-21 19:38:28 -04:00
trace_events_filter_test.h
…
trace_events_filter.c
tracing: Avoid memory leak in process_system_preds()
2020-01-09 10:20:00 +01:00
trace_events_hist.c
tracing: Fix memory leaks in trace_events_hist.c
2020-05-10 10:31:28 +02:00
trace_events_trigger.c
tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation
2020-04-21 09:04:59 +02:00
trace_events.c
tracing: Fix lock inversion in trace_event_enable_tgid_record()
2020-01-09 10:19:59 +01:00
trace_export.c
…
trace_functions_graph.c
fgraph: Remove redundant ftrace_graph_notrace_addr() test
2019-07-30 21:50:03 -04:00
trace_functions.c
…
trace_hwlat.c
tracing/hwlat: Don't ignore outer-loop duration when calculating max_latency
2019-10-12 20:49:33 -04:00
trace_irqsoff.c
Merge tag 'trace-v5.1' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
2019-03-11 17:01:32 -07:00
trace_kdb.c
tracing: Silence GCC 9 array bounds warning
2019-05-25 23:04:30 -04:00
trace_kprobe_selftest.c
…
trace_kprobe_selftest.h
…
trace_kprobe.c
tracing/probe: Fix bpf_task_fd_query() for kprobes and uprobes
2020-06-24 17:50:43 +02:00
trace_mmiotrace.c
…
trace_nop.c
…
trace_output.c
tracing: Be more clever when dumping hex in __print_hex()
2019-09-17 11:21:28 -04:00
trace_output.h
…
trace_preemptirq.c
kprobes: Prohibit probing on hardirq tracers
2019-02-13 08:16:40 +01:00
trace_printk.c
tracing: Add locked_down checks to the open calls of files created for tracefs
2019-10-12 20:48:06 -04:00
trace_probe_tmpl.h
tracing/probe: Support user-space dereference
2019-05-25 23:04:42 -04:00
trace_probe.c
tracing/probe: Fix memleak in fetch_op_data operations
2020-06-24 17:50:51 +02:00
trace_probe.h
tracing/uprobe: Fix to make trace_uprobe_filter alignment safe
2020-02-05 21:22:53 +00:00
trace_sched_switch.c
tracing: Fix sched switch start/stop refcount racy updates
2020-02-11 04:35:07 -08:00
trace_sched_wakeup.c
kernel/trace: Fix do not unregister tracepoints when register sched_migrate_task fail
2020-01-14 20:08:22 +01:00
trace_selftest_dynamic.c
…
trace_selftest.c
function_graph: Have selftest also emulate tr->reset() as it did with tr->init()
2019-04-21 19:46:56 -04:00
trace_seq.c
…
trace_stack.c
tracing: Have stack tracer compile when MCOUNT_INSN_SIZE is not defined
2020-01-14 20:08:22 +01:00
trace_stat.c
tracing: Fix very unlikely race of registering two stat tracers
2020-02-24 08:36:30 +01:00
trace_stat.h
…
trace_syscalls.c
syscalls: Remove start and number from syscall_get_arguments() args
2019-04-05 09:26:43 -04:00
trace_uprobe.c
tracing/probe: Fix bpf_task_fd_query() for kprobes and uprobes
2020-06-24 17:50:43 +02:00
trace.c
tracing: Add a vmalloc_sync_mappings() for safe measure
2020-05-14 07:58:25 +02:00
trace.h
ftrace: Protect ftrace_graph_hash with ftrace_sync
2020-02-11 04:35:28 -08:00
tracing_map.c
tracing: Have the histogram compare functions convert to u64 first
2020-01-09 10:20:00 +01:00
tracing_map.h
…