Linus Torvalds 9d235ac01f
Merge branch 'ucount-fixes-for-v5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace ...
Pull ucounts fixes from Eric Biederman:
"There has been one very hard to track down bug in the ucount code that
we have been tracking since roughly v5.14 was released. Alex managed
to find a reliable reproducer a few days ago and then I was able to
instrument the code and figure out what the issue was.
It turns out the sigqueue_alloc single atomic operation optimization
did not play nicely with ucounts multiple level rlimits. It turned out
that either sigqueue_alloc or sigqueue_free could be operating on
multiple levels and trigger the conditions for the optimization on
more than one level at the same time.
To deal with that situation I have introduced inc_rlimit_get_ucounts
and dec_rlimit_put_ucounts that just focuses on the optimization and
the rlimit and ucount changes.
While looking into the big bug I found I couple of other little issues
so I am including those fixes here as well.
When I have time I would very much like to dig into process ownership
of the shared signal queue and see if we could pick a single owner for
the entire queue so that all of the rlimits can count to that owner.
That should entirely remove the need to call get_ucounts and
put_ucounts in sigqueue_alloc and sigqueue_free. It is difficult
because Linux unlike POSIX supports setuid that works on a single
thread"
* 'ucount-fixes-for-v5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace:
ucounts: Move get_ucounts from cred_alloc_blank to key_change_session_keyring
ucounts: Proper error handling in set_cred_ucounts
ucounts: Pair inc_rlimit_ucounts with dec_rlimit_ucoutns in commit_creds
ucounts: Fix signal ucount refcounting
2021-10-21 17:27:17 -10:00
2021-08-19 15:07:03 +02:00
2021-09-02 22:49:16 +02:00
2021-10-12 17:35:18 -07:00
2021-08-04 09:53:34 +01:00
2021-08-13 09:38:04 +02:00
2021-08-23 18:05:31 -04:00
2021-09-07 12:38:59 -07:00
2021-10-20 10:42:49 -07:00
2021-08-31 16:43:06 -07:00
2021-09-03 16:20:37 -07:00
2021-09-20 12:43:34 +01:00
2021-10-05 15:39:50 +02:00
2021-09-01 15:25:28 -07:00
2021-08-23 11:06:28 +01:00
2021-09-08 12:55:35 -07:00
2021-09-07 14:02:58 -07:00
2021-09-01 10:29:29 -07:00
2021-10-14 12:47:29 +01:00
2021-08-29 14:47:42 +03:00
2021-09-04 10:25:26 -07:00
2021-09-14 10:41:30 +02:00
2021-08-30 19:30:37 +02:00
2021-10-07 16:51:57 +02:00
2021-09-03 09:58:10 -07:00
2021-09-03 10:08:28 -07:00
2021-08-31 09:41:22 -07:00
2021-08-13 10:27:49 +02:00
2021-08-31 09:41:22 -07:00
2021-08-16 10:53:01 -06:00
2021-08-23 12:54:30 -06:00
2021-09-02 15:09:46 -07:00
2021-09-09 19:14:33 -04:00
2021-08-17 00:45:07 +02:00
2021-08-23 17:50:24 -07:00
2021-09-14 11:09:50 -07:00
2021-08-20 00:09:49 +02:00
2021-08-25 19:41:39 -07:00
2021-09-24 16:13:35 -07:00
2021-08-16 10:50:32 -06:00
2021-09-01 10:29:10 +02:00
2021-09-13 16:35:58 -07:00
2021-09-13 16:35:58 -07:00
2021-09-01 15:26:45 -07:00
2021-09-03 09:58:17 -07:00
2021-09-08 15:32:35 -07:00
2021-09-13 10:43:04 -07:00
2021-09-12 16:09:26 -07:00
2021-09-13 10:18:28 -07:00
2021-09-13 10:43:04 -07:00
2021-09-15 12:04:28 -07:00
2021-08-18 22:33:28 +02:00
2021-08-09 20:17:36 +01:00
2021-09-11 00:41:21 +02:00
2021-09-07 15:42:10 +02:00
2021-10-18 20:22:03 -10:00
2021-09-21 17:34:53 +02:00
2021-08-20 12:32:59 +02:00
2021-08-24 17:09:01 -05:00
2021-09-08 11:50:24 -07:00
2021-08-26 16:52:03 -07:00
2021-08-17 17:29:10 +02:00
2021-08-31 14:55:09 -07:00
2021-09-03 10:34:44 -07:00
2021-08-10 12:23:46 +02:00
2021-08-18 13:27:49 +02:00
2021-08-19 09:02:39 +02:00
2021-08-14 09:18:36 +02:00
2021-08-29 19:14:19 +05:30
2021-10-18 20:22:03 -10:00
2021-09-07 21:17:28 +02:00
2021-08-19 11:19:41 +01:00
2021-08-26 15:32:28 -04:00
2021-10-05 12:38:39 +01:00
2021-08-24 07:38:29 -07:00
2021-08-28 01:33:02 +02:00
2021-08-20 11:39:26 +01:00
2021-08-26 15:32:10 -04:00
2021-08-10 13:08:49 +02:00
2021-09-06 07:20:56 -04:00
2021-09-03 15:33:47 -07:00
2021-09-09 12:45:26 -07:00
2021-08-27 13:34:02 +01:00
2021-08-27 13:34:03 +01:00
2021-08-11 13:50:53 +02:00
2021-08-03 14:31:40 +02:00
2021-09-23 19:26:54 +02:00
2021-10-15 21:02:50 -06:00
2021-09-08 11:50:24 -07:00
2021-09-03 09:58:13 -07:00
2021-08-10 14:42:49 +02:00
2021-08-10 17:57:23 +02:00
2021-09-03 09:58:16 -07:00
2021-09-08 18:45:53 -07:00
2021-08-12 17:26:24 +02:00
2021-08-26 10:18:56 +02:00
2021-08-04 12:35:07 +01:00
2021-08-05 11:46:42 +01:00
2021-08-13 06:41:22 -07:00
2021-08-19 10:41:08 +02:00
2021-08-19 10:41:08 +02:00
2021-08-10 22:50:07 +02:00
2021-08-23 13:10:37 -06:00
2021-08-20 17:14:35 +02:00
2021-08-16 21:26:33 -07:00
2021-09-03 10:44:35 -07:00
2021-08-18 07:23:15 -06:00
2021-08-10 10:59:20 +02:00
2021-09-22 14:29:32 +01:00
2021-08-02 18:14:21 +01:00
2021-08-19 09:02:55 +09:00
2021-08-20 11:31:42 -07:00
2021-09-23 11:01:12 -04:00
2021-09-06 06:30:45 -04:00
2021-08-18 08:27:30 +02:00
2021-09-03 08:06:02 -06:00
2021-08-13 18:37:38 +02:00
2021-08-17 19:08:49 +02:00
2021-08-05 12:08:15 +02:00
2021-08-11 09:50:11 -06:00
2021-09-19 12:08:37 +01:00
2021-09-14 13:23:22 -07:00
2021-09-03 10:08:28 -07:00
2021-09-08 11:50:23 -07:00
2021-10-18 20:22:02 -10:00
2021-09-03 09:58:17 -07:00
2021-09-01 08:35:06 -07:00
2021-09-24 16:13:35 -07:00
2021-08-19 13:06:53 +01:00
2021-08-19 09:02:55 +09:00
2021-08-09 15:49:00 -07:00
2021-09-07 11:03:45 -07:00
2021-09-03 18:42:01 +02:00
2021-09-16 13:05:42 -07:00
2021-08-20 12:32:58 +02:00
2021-09-08 12:55:35 -07:00
2021-08-26 10:36:51 -06:00
2021-08-16 14:42:22 +02:00
2021-08-24 09:16:20 +02:00
2021-08-17 19:05:29 +02:00
2021-08-23 13:19:12 +02:00
2021-09-05 20:58:50 +01:00
2021-08-25 15:20:25 +01:00
2021-08-27 16:37:17 -04:00
2021-08-27 16:37:17 -04:00
2021-08-16 18:55:32 +02:00
2021-09-14 09:02:50 +02:00
2021-08-15 09:56:03 -05:00
2021-08-05 21:21:58 +02:00
2021-09-07 12:27:27 -07:00
2021-08-25 15:43:26 -05:00
2021-09-08 11:50:25 -07:00
2021-09-13 10:18:28 -07:00
2021-09-17 13:52:17 +01:00
2021-09-08 11:50:24 -07:00
2021-09-08 11:50:24 -07:00
2021-09-08 12:55:35 -07:00
2021-09-08 12:55:35 -07:00
2021-08-18 17:32:42 -05:00
2021-09-07 19:13:42 -07:00
2021-09-02 17:59:58 +02:00
2021-08-19 14:13:28 +01:00
2021-09-07 19:13:42 -07:00
2021-09-07 19:13:42 -07:00
2021-10-01 13:57:54 +02:00
2021-09-07 14:04:59 +01:00
2021-08-10 12:53:04 +02:00
2021-08-18 11:39:46 -07:00
2021-09-20 22:28:47 +02:00
2021-08-18 16:08:11 +02:00
2021-08-26 11:28:07 -07:00
2021-08-16 18:45:29 +02:00
2021-08-26 11:27:51 -07:00
2021-08-18 22:08:24 +02:00
2021-08-10 17:09:59 +02:00
2021-08-14 12:48:07 +02:00
2021-08-17 19:06:04 +02:00
2021-09-03 15:33:47 -07:00
2021-08-13 17:49:05 -07:00
2021-09-02 21:38:56 +02:00
2021-10-07 16:51:57 +02:00
2021-08-04 14:23:31 -05:00
2021-08-17 17:36:48 +02:00
2021-08-17 17:36:48 +02:00
2021-08-06 13:41:48 -07:00
2021-08-10 11:00:53 -07:00
2021-08-06 13:41:48 -07:00
2021-08-26 13:40:35 +01:00
2021-08-11 18:42:53 +02:00
2021-08-17 17:37:26 +02:00
2021-08-17 17:12:22 +02:00
2021-08-17 17:50:51 +02:00
2021-08-17 17:50:51 +02:00
2021-09-02 22:07:17 +02:00
2021-08-24 19:52:40 -03:00
2021-10-01 13:57:57 +02:00
2021-10-18 20:22:03 -10:00
2021-08-10 10:10:10 +02:00
2021-08-13 09:12:53 +02:00
2021-08-13 09:14:36 +02:00
2021-09-03 09:58:12 -07:00
2021-09-09 10:57:52 +01:00
2021-09-04 10:22:01 +02:00
2021-08-31 16:43:06 -07:00
2021-08-17 17:43:24 +02:00
2021-08-17 19:06:13 +02:00
2021-08-17 19:06:13 +02:00
2021-08-17 19:06:13 +02:00
2021-08-17 17:43:24 +02:00
2021-08-06 13:41:48 -07:00
2021-08-17 11:47:43 +02:00
2021-08-17 19:09:27 +02:00
2021-08-19 09:02:55 +09:00
2021-08-19 09:02:55 +09:00
2021-09-03 09:58:17 -07:00
2021-09-09 13:25:49 -07:00
2021-08-17 11:47:53 -04:00
2021-08-05 14:47:31 +02:00
2021-08-14 15:43:28 +02:00
2021-09-08 11:50:28 -07:00
2021-08-09 14:58:29 +03:00
2021-09-08 17:44:26 +02:00
2021-09-05 11:50:41 -07:00
2021-10-18 18:12:09 -04:00
2021-09-22 10:24:01 -04:00
2021-08-16 11:37:21 -04:00
2021-09-08 15:32:35 -07:00
2021-09-15 09:22:35 -06:00
2021-09-08 12:55:35 -07:00
2021-10-18 16:02:30 -05:00
2021-09-03 09:58:16 -07:00
2021-09-06 07:20:57 -04:00
2021-08-26 10:36:51 -06:00
2021-08-11 09:50:11 -06:00
2021-09-06 07:20:57 -04:00
2021-08-10 11:50:55 -04:00
2021-09-03 09:58:16 -07:00
2021-09-08 11:50:24 -07:00
2021-09-03 09:58:17 -07:00
2021-08-11 06:44:24 -04:00
2021-08-30 13:42:10 -07:00
2021-08-22 10:28:08 +02:00
2021-09-13 07:53:27 -10:00
2021-09-03 10:08:28 -07:00
2021-08-17 19:05:11 +02:00
2021-08-05 14:37:04 +02:00
9d235ac01f