Eiichi Tsukata a2d859e3fc sctp: account stream padding length for reconf chunk ...

sctp_make_strreset_req() makes repeated calls to sctp_addto_chunk()
which will automatically account for padding on each call. inreq and
outreq are already 4 bytes aligned, but the payload is not and doing
SCTP_PAD4(a + b) (which _sctp_make_chunk() did implicitly here) is
different from SCTP_PAD4(a) + SCTP_PAD4(b) and not enough. It led to
possible attempt to use more buffer than it was allocated and triggered
a BUG_ON.

Cc: Vlad Yasevich <vyasevich@gmail.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Greg KH <gregkh@linuxfoundation.org>
Fixes: cc16f00f65 ("sctp: add support for generating stream reconf ssn reset request chunk")
Reported-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Link: https://lore.kernel.org/r/b97c1f8b0c7ff79ac4ed206fc2c49d3612e0850c.1634156849.git.mleitner@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

2021-10-14 07:15:22 -07:00

..

associola.c

sctp: enable PLPMTUD when the transport is ready

2021-06-22 11:28:52 -07:00

auth.c

sctp: move the active_key update after sh_keys is added

2021-08-03 11:43:43 +01:00

bind_addr.c

sctp: validate from_addr_param return

2021-06-28 15:34:50 -07:00

chunk.c

…

debug.c

sctp: add the probe timer in transport for PLPMTUD

2021-06-22 11:28:52 -07:00

diag.c

net: Use nlmsg_unicast() instead of netlink_unicast()

2021-07-13 09:28:29 -07:00

endpointola.c

…

input.c

sctp: break out if skb_header_pointer returns NULL in sctp_rcv_ootb

2021-09-24 10:36:19 +01:00

inqueue.c

…

ipv6.c

sctp: delete addr based on sin6_scope_id

2021-07-26 12:34:03 +01:00

Kconfig

sctp: create udp4 sock and add its encap_rcv

2020-10-30 15:23:52 -07:00

Makefile

…

objcnt.c

…

offload.c

sctp: remove the NETIF_F_SG flag before calling skb_segment

2021-01-16 19:05:59 -08:00

output.c

sctp: do not update transport pathmtu if SPP_PMTUD_ENABLE is not set

2021-07-21 14:17:58 -07:00

outqueue.c

sctp: do the basic send and recv for PLPMTUD probe

2021-06-22 11:28:52 -07:00

primitive.c

…

proc.c

net: fix iteration for sctp transport seq_files

2021-02-08 10:15:49 -08:00

protocol.c

sctp: move 198 addresses from unusable to private scope

2021-07-01 11:47:13 -07:00

sm_make_chunk.c

sctp: account stream padding length for reconf chunk

2021-10-14 07:15:22 -07:00

sm_sideeffect.c

sctp: add the probe timer in transport for PLPMTUD

2021-06-22 11:28:52 -07:00

sm_statefuns.c

sctp: improve the code for pmtu probe send and recv update

2021-07-25 23:06:02 +01:00

sm_statetable.c

sctp: add the probe timer in transport for PLPMTUD

2021-06-22 11:28:52 -07:00

socket.c

sctp: trim optlen when it's a huge value in sctp_setsockopt

2021-07-18 09:47:29 -07:00

stream_interleave.c

…

stream_sched_prio.c

…

stream_sched_rr.c

…

stream_sched.c

…

stream.c

…

sysctl.c

sctp: add probe_interval in sysctl and sock/asoc/transport

2021-06-22 11:28:51 -07:00

transport.c

sctp: send pmtu probe only if packet loss in Search Complete state

2021-07-25 23:06:02 +01:00

tsnmap.c

net: sctp: trivial: fix typo in comment

2021-03-04 13:48:32 -08:00

ulpevent.c

…

ulpqueue.c

net: sctp: ulpqueue.c: delete duplicated word

2020-08-24 16:21:43 -07:00