Liping Zhang 53b56da83d
netfilter: ctnetlink: make it safer when updating ct->status ...
After converting to use rcu for conntrack hash, one CPU may update
the ct->status via ctnetlink, while another CPU may process the
packets and update the ct->status.
So the non-atomic operation "ct->status |= status;" via ctnetlink
becomes unsafe, and this may clear the IPS_DYING_BIT bit set by
another CPU unexpectedly. For example:
CPU0 CPU1
ctnetlink_change_status __nf_conntrack_find_get
old = ct->status nf_ct_gc_expired
- nf_ct_kill
- test_and_set_bit(IPS_DYING_BIT
new = old | status; -
ct->status = new; <-- oops, _DYING_ is cleared!
Now using a series of atomic bit operation to solve the above issue.
Also note, user shouldn't set IPS_TEMPLATE, IPS_SEQ_ADJUST directly,
so make these two bits be unchangable too.
If we set the IPS_TEMPLATE_BIT, ct will be freed by nf_ct_tmpl_free,
but actually it is alloced by nf_conntrack_alloc.
If we set the IPS_SEQ_ADJUST_BIT, this may cause the NULL pointer
deference, as the nfct_seqadj(ct) maybe NULL.
Last, add some comments to describe the logic change due to the
commit a963d710f376507f69c4zlpnobody@gmail.com >
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org >
2017-04-24 20:06:28 +02:00
2017-02-10 16:00:01 +01:00
2017-01-24 13:52:00 +01:00
2016-09-09 09:53:35 -03:00
2016-08-22 22:43:35 +02:00
2017-01-05 13:02:25 +00:00
2016-11-29 09:00:30 +01:00
2017-04-24 20:06:28 +02:00
2017-01-31 12:31:54 -05:00
2016-11-22 08:58:17 -08:00
2017-03-02 08:42:42 +01:00
2017-02-10 13:18:33 -05:00
2017-01-02 10:55:28 +02:00
2016-11-13 12:35:13 -05:00
2017-02-21 13:25:50 -08:00
2017-02-27 18:43:45 -08:00
2017-02-27 18:43:45 -08:00
2017-02-27 18:43:45 -08:00
2017-01-26 08:34:19 +01:00
2016-10-18 10:05:42 -06:00
2016-09-02 10:46:44 -07:00
2017-02-16 19:34:01 -05:00
2016-11-13 00:57:53 -05:00
2016-09-29 19:05:06 -05:00
2017-03-07 14:10:17 +01:00
2016-12-07 10:45:57 +01:00
2016-08-02 17:31:41 -04:00
2016-12-21 06:59:13 -02:00
2016-11-16 15:43:10 -02:00
2016-05-03 14:59:30 -07:00
2016-10-25 11:08:30 +08:00
2017-02-10 14:43:00 -05:00
2016-07-20 23:49:49 -04:00
2016-11-21 09:52:02 -05:00
2016-07-20 12:37:39 -07:00
2016-08-05 09:00:54 -04:00
2017-01-30 10:14:28 -05:00
2016-10-03 09:11:14 -07:00
2017-03-02 20:51:15 -05:00
2016-11-04 14:45:23 -04:00
2017-02-02 04:36:12 +13:00
2016-10-01 07:32:32 +02:00
2016-10-27 16:16:09 -04:00
2016-06-15 09:29:17 +02:00
2016-06-07 16:25:49 -07:00
2016-11-18 17:23:17 +00:00
2016-06-17 13:24:05 +02:00
2016-06-18 22:11:39 -07:00
2017-02-03 15:21:21 -05:00
2017-01-10 14:05:11 -05:00
2017-02-03 15:21:21 -05:00
2016-07-25 10:55:39 -07:00
2016-12-10 23:29:11 -05:00
2016-08-22 16:25:15 -07:00
2016-09-25 23:34:19 +02:00
2017-02-22 16:09:04 -05:00
2017-02-03 15:16:45 -05:00
2017-01-17 15:22:05 -05:00
2016-11-03 15:41:11 -04:00
2016-11-03 15:41:11 -04:00
2016-10-23 19:35:24 -04:00
2016-11-30 08:59:26 -08:00
2016-08-17 11:13:08 +02:00
2017-02-23 10:46:07 -05:00
2017-04-21 13:55:33 -04:00
2017-01-27 10:25:34 -05:00
2016-08-22 16:25:15 -07:00
2017-04-14 17:51:16 -07:00
2016-06-27 16:31:25 +01:00
2017-02-07 18:16:45 +01:00
2017-02-17 12:27:37 +01:00
2017-02-14 22:18:05 -05:00
2016-08-22 16:25:15 -07:00
2017-01-31 08:32:13 -07:00
2016-07-11 10:49:52 -03:00
2017-02-23 10:46:08 -05:00
2016-12-02 10:51:49 -05:00
2016-10-30 19:10:14 -06:00
2016-10-24 08:12:35 -02:00
2016-09-09 11:16:36 -03:00
2016-08-23 16:28:04 -03:00
2016-08-12 16:57:20 -07:00
2017-01-17 14:38:43 -05:00
2017-02-24 17:46:56 -08:00
2017-02-19 18:15:12 -05:00
2017-02-19 18:15:12 -05:00
2016-11-22 13:11:55 -07:00
2016-08-15 11:07:21 -07:00
2017-02-03 15:21:21 -05:00
2016-11-30 10:04:25 -05:00
2017-02-20 11:13:37 -05:00
2017-02-23 21:51:39 +01:00
2016-06-16 14:00:50 -07:00
2017-01-09 16:07:41 -05:00
2016-09-26 15:20:37 -04:00
2016-08-02 19:35:21 -04:00
2016-08-02 19:35:21 -04:00
2017-02-09 15:17:30 +01:00
2017-02-03 14:35:43 +13:00
2016-05-17 17:14:21 -06:00
2017-02-09 22:59:34 -05:00
2017-03-09 13:22:28 -08:00
2017-02-15 11:56:07 -06:00
2016-05-30 12:41:44 -03:00
2017-02-17 12:08:05 -05:00
2016-09-23 07:19:06 -04:00
2016-09-27 21:52:00 -04:00
2016-09-27 21:52:00 -04:00
2017-01-24 13:44:28 -05:00
2016-05-08 23:46:14 -04:00
2017-02-23 10:55:08 -05:00
2016-08-02 19:35:31 -04:00
2016-05-05 17:38:53 -07:00
2017-01-18 10:43:15 -08:00
2017-02-20 11:13:37 -05:00
2017-02-19 18:17:59 -05:00
2017-02-14 19:47:16 -07:00
2016-11-09 20:40:06 -05:00
2017-01-16 14:47:21 -05:00
2017-02-23 10:55:08 -05:00
2017-02-23 10:55:08 -05:00
2017-01-12 11:51:25 +01:00
2017-02-10 15:13:26 +01:00
2017-02-09 11:43:15 -08:00
2016-05-04 08:34:14 +02:00
2017-01-09 16:07:41 -05:00
2017-01-09 16:07:38 -05:00
2017-02-02 23:34:19 -05:00
2016-10-31 10:56:47 -04:00
2017-04-03 01:06:00 -04:00
2016-05-05 17:38:53 -07:00
2016-09-20 18:12:38 +05:30
2016-08-02 17:31:41 -04:00
2017-02-18 21:44:59 -08:00
2017-01-29 19:17:23 -05:00
2017-01-10 18:31:55 -08:00
2016-08-26 21:38:41 -07:00
2017-01-20 12:10:17 -05:00
2016-12-16 00:13:39 +02:00
2016-05-10 12:25:04 -04:00
2016-11-22 12:07:02 +01:00
2017-02-02 21:58:02 -05:00
2017-03-09 17:01:09 -08:00
2016-05-20 17:58:30 -07:00
2016-11-16 16:16:08 -02:00
2016-11-16 15:13:18 -02:00
2016-11-17 08:33:20 -07:00
2016-12-16 00:13:38 +02:00
2017-02-13 14:33:56 -02:00
2016-08-01 21:44:52 +03:00
2016-12-16 00:13:32 +02:00
2016-12-16 00:13:32 +02:00
2017-02-27 16:31:23 +02:00
2016-06-10 23:03:55 -07:00
2017-04-11 00:28:41 +03:00
2016-12-16 00:13:41 +02:00
2016-08-09 13:42:38 +03:00
2016-11-28 01:31:31 +02:00
2016-06-09 10:14:39 +02:00
2016-09-09 09:10:07 +02:00
53b56da83d