Eric Dumazet
3e13ce88a3
net/sched: sch_taprio: fix undefined behavior in ktime_mono_to_any
[ Upstream commit 6dc25401cba4d428328eade8ceae717633fdd702 ]
1) if q->tk_offset == TK_OFFS_MAX, then get_tcp_tstamp() calls
ktime_mono_to_any() with out-of-bound value.
2) if q->tk_offset is changed in taprio_parse_clockid(),
taprio_get_time() might also call ktime_mono_to_any()
with out-of-bound value as sysbot found:
UBSAN: array-index-out-of-bounds in kernel/time/timekeeping.c:908:27
index 3 is out of range for type 'ktime_t *[3]'
CPU: 1 PID: 25668 Comm: kworker/u4:0 Not tainted 5.15.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: bat_events batadv_iv_send_outstanding_bat_ogm_packet
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
ubsan_epilogue+0xb/0x5a lib/ubsan.c:151
__ubsan_handle_out_of_bounds.cold+0x62/0x6c lib/ubsan.c:291
ktime_mono_to_any+0x1d4/0x1e0 kernel/time/timekeeping.c:908
get_tcp_tstamp net/sched/sch_taprio.c:322 [inline]
get_packet_txtime net/sched/sch_taprio.c:353 [inline]
taprio_enqueue_one+0x5b0/0x1460 net/sched/sch_taprio.c:420
taprio_enqueue+0x3b1/0x730 net/sched/sch_taprio.c:485
dev_qdisc_enqueue+0x40/0x300 net/core/dev.c:3785
__dev_xmit_skb net/core/dev.c:3869 [inline]
__dev_queue_xmit+0x1f6e/0x3630 net/core/dev.c:4194
batadv_send_skb_packet+0x4a9/0x5f0 net/batman-adv/send.c:108
batadv_iv_ogm_send_to_if net/batman-adv/bat_iv_ogm.c:393 [inline]
batadv_iv_ogm_emit net/batman-adv/bat_iv_ogm.c:421 [inline]
batadv_iv_send_outstanding_bat_ogm_packet+0x6d7/0x8e0 net/batman-adv/bat_iv_ogm.c:1701
process_one_work+0x9b2/0x1690 kernel/workqueue.c:2298
worker_thread+0x658/0x11f0 kernel/workqueue.c:2445
kthread+0x405/0x4f0 kernel/kthread.c:327
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
Fixes: 7ede7b0348 ("taprio: make clock reference conversions easier")
Fixes: 5400206610 ("taprio: Adjust timestamps for TCP packets")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Vedang Patel <vedang.patel@intel.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Link: https://lore.kernel.org/r/20211108180815.1822479-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-11-18 19:17:12 +01:00
..
2021-09-05 08:36:44 +09:00
2021-08-13 16:30:35 -07:00
2021-11-18 19:17:06 +01:00
2021-10-26 14:47:12 +01:00
2021-11-18 19:16:22 +01:00
2021-09-28 09:29:28 +02:00
2021-11-18 19:16:44 +01:00
2021-09-14 12:51:15 +01:00
2021-11-18 19:16:03 +01:00
2021-11-18 19:17:11 +01:00
2021-11-18 19:16:33 +01:00
2021-11-18 19:17:06 +01:00
2021-11-18 19:17:06 +01:00
2021-11-18 19:17:11 +01:00
2021-11-18 19:16:44 +01:00
2021-09-09 11:00:20 +01:00
2021-11-18 19:16:25 +01:00
2021-09-07 14:06:08 +01:00
2021-11-18 19:16:02 +01:00
2021-11-18 19:16:25 +01:00
2021-09-01 17:18:56 -07:00
2021-11-18 19:17:02 +01:00
2021-08-30 12:23:18 +01:00
2021-10-05 13:11:09 +01:00
2021-10-13 17:44:29 -07:00
2021-08-19 18:09:18 -07:00
2021-09-10 10:00:59 +01:00
2021-09-02 11:37:02 +01:00
2021-08-18 15:35:50 -07:00
2021-11-18 19:16:25 +01:00
2021-11-18 19:17:12 +01:00
2021-11-18 19:16:43 +01:00
2021-10-28 13:04:28 +01:00
2021-11-18 19:17:11 +01:00
2021-11-18 19:16:58 +01:00
2021-10-26 13:43:07 +01:00
2021-10-28 14:41:20 +01:00
2021-10-26 12:29:33 -07:00
2021-09-06 02:25:16 -04:00
2021-11-18 19:16:26 +01:00
2021-09-23 10:11:12 +02:00
2021-08-31 16:43:06 -07:00