Christophe Leroy
43ae0ccc4d
powerpc/fixmap: Fix VM debug warning on unmap
[ Upstream commit aec982603aa8cc0a21143681feb5f60ecc69d718 ]
Unmapping a fixmap entry is done by calling __set_fixmap()
with FIXMAP_PAGE_CLEAR as flags.
Today, powerpc __set_fixmap() calls map_kernel_page().
map_kernel_page() is not happy when called a second time
for the same page.
WARNING: CPU: 0 PID: 1 at arch/powerpc/mm/pgtable.c:194 set_pte_at+0xc/0x1e8
CPU: 0 PID: 1 Comm: swapper Not tainted 5.16.0-rc3-s3k-dev-01993-g350ff07feb7d-dirty #682
NIP: c0017cd4 LR: c00187f0 CTR: 00000010
REGS: e1011d50 TRAP: 0700 Not tainted (5.16.0-rc3-s3k-dev-01993-g350ff07feb7d-dirty)
MSR: 00029032 <EE,ME,IR,DR,RI> CR: 42000208 XER: 00000000
GPR00: c0165fec e1011e10 c14c0000 c0ee2550 ff800000 c0f3d000 00000000 c001686c
GPR08: 00001000 b00045a9 00000001 c0f58460 c0f50000 00000000 c0007e10 00000000
GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
GPR24: 00000000 00000000 c0ee2550 00000000 c0f57000 00000ff8 00000000 ff800000
NIP [c0017cd4] set_pte_at+0xc/0x1e8
LR [c00187f0] map_kernel_page+0x9c/0x100
Call Trace:
[e1011e10] [c0736c68] vsnprintf+0x358/0x6c8 (unreliable)
[e1011e30] [c0165fec] __set_fixmap+0x30/0x44
[e1011e40] [c0c13bdc] early_iounmap+0x11c/0x170
[e1011e70] [c0c06cb0] ioremap_legacy_serial_console+0x88/0xc0
[e1011e90] [c0c03634] do_one_initcall+0x80/0x178
[e1011ef0] [c0c0385c] kernel_init_freeable+0xb4/0x250
[e1011f20] [c0007e34] kernel_init+0x24/0x140
[e1011f30] [c0016268] ret_from_kernel_thread+0x5c/0x64
Instruction dump:
7fe3fb78 48019689 80010014 7c630034 83e1000c 5463d97e 7c0803a6 38210010
4e800020 81250000 712a0001 41820008 <0fe00000> 9421ffe0 93e1001c 48000030
Implement unmap_kernel_page() which clears an existing pte.
Reported-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Tested-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/b0b752f6f6ecc60653e873f385c6f0dce4e9ab6a.1638789098.git.christophe.leroy@csgroup.eu
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-02-16 12:56:12 +01:00
..
2022-02-16 12:56:12 +01:00
2022-02-16 12:56:12 +01:00
2021-08-27 00:56:52 +10:00
2021-08-25 13:35:49 +10:00
2021-09-13 10:18:28 -07:00
2021-06-25 00:06:56 +10:00
2021-08-25 13:35:49 +10:00
2021-06-10 21:44:57 +10:00
2021-08-25 13:35:49 +10:00
2021-09-01 21:25:43 +10:00
2021-04-14 23:04:19 +10:00
2021-06-16 00:16:47 +10:00
2021-05-26 13:20:52 +02:00
2021-10-07 18:52:33 +11:00
2021-09-08 15:32:35 -07:00
2021-04-08 21:17:42 +10:00
2021-03-14 20:32:24 +11:00
2021-01-29 10:05:51 +05:30
2021-06-21 09:22:34 +10:00
2021-02-09 00:10:49 +11:00
2021-03-01 12:33:31 +11:00
2021-02-09 00:02:12 +11:00
2021-08-10 23:14:55 +10:00
2021-06-10 22:12:12 +10:00
2021-08-15 13:49:24 +10:00
2021-01-20 15:58:19 +11:00
2021-08-13 22:04:27 +10:00
2022-02-16 12:56:12 +01:00
2021-04-07 10:56:52 +02:00
2021-03-23 14:08:18 -04:00
2021-03-26 23:19:43 +11:00
2021-06-25 00:06:55 +10:00
2021-01-24 10:34:53 -08:00
2021-02-11 23:35:06 +11:00
2021-06-23 00:19:08 +10:00
2021-03-24 14:09:30 +11:00
2022-01-27 11:04:07 +01:00
2021-03-24 14:09:29 +11:00
2021-06-17 00:09:06 +10:00
2021-10-07 19:54:55 +11:00
2021-05-07 00:26:34 -07:00
2021-08-27 00:56:54 +10:00
2021-08-12 22:21:57 +10:00
2021-06-15 23:35:57 +10:00
2021-04-25 21:29:04 +10:00
2021-04-14 23:04:16 +10:00
2021-03-11 09:53:38 -07:00
2021-03-24 14:09:30 +11:00
2021-06-17 00:09:09 +10:00
2021-06-10 22:12:15 +10:00
2022-02-01 17:27:03 +01:00
2021-02-10 14:31:08 +11:00
2021-06-22 23:35:37 +10:00
2021-06-25 14:47:19 +10:00
2022-02-01 17:27:03 +01:00
2021-08-10 23:14:59 +10:00
2021-06-25 00:06:55 +10:00
2021-02-03 09:46:36 +11:00
2021-01-31 22:35:49 +11:00
2021-08-10 23:14:55 +10:00
2021-06-23 00:19:08 +10:00
2021-08-10 23:14:56 +10:00
2021-06-29 10:53:55 -07:00
2021-02-09 00:02:12 +11:00
2020-12-11 09:53:10 +11:00
2021-05-02 23:35:32 +10:00
2021-06-25 00:06:56 +10:00
2021-11-18 19:16:51 +01:00
2021-08-10 23:14:57 +10:00
2021-05-02 23:35:32 +10:00
2021-04-20 14:22:23 +10:00
2021-02-09 01:09:44 +11:00
2021-07-01 11:06:03 -07:00
2021-07-02 12:54:34 -07:00
2021-02-09 01:09:44 +11:00
2021-05-12 11:07:38 +10:00
2021-08-25 16:37:18 +10:00
2021-08-10 23:15:01 +10:00
2021-08-25 13:35:47 +10:00
2022-02-01 17:27:09 +01:00
2021-02-11 23:35:36 +11:00
2021-06-25 00:06:55 +10:00
2021-06-17 00:09:11 +10:00
2021-08-13 22:04:27 +10:00
2021-06-10 21:44:58 +10:00
2021-05-28 22:54:27 +10:00
2021-09-03 22:54:12 +10:00
2021-05-26 13:20:52 +02:00
2021-02-11 23:35:12 +11:00
2021-08-25 16:37:17 +10:00
2021-04-14 23:04:16 +10:00
2021-08-10 23:14:55 +10:00
2021-10-07 19:52:58 +11:00
2021-06-21 21:13:21 +10:00
2021-06-25 00:07:10 +10:00
2021-08-25 13:35:49 +10:00
2021-08-04 10:53:39 +10:00
2021-03-26 23:19:43 +11:00
2021-01-29 10:05:51 +05:30
2021-06-25 14:47:18 +10:00
2021-03-10 11:15:00 +11:00
2022-02-01 17:27:01 +01:00
2021-08-23 19:28:21 +10:00
2021-08-27 00:56:54 +10:00
2022-02-01 17:27:01 +01:00
2021-06-10 22:12:13 +10:00
2021-07-08 11:48:23 -07:00
2021-08-27 00:56:54 +10:00
2021-05-12 11:07:39 +10:00
2021-08-23 19:28:20 +10:00
2021-06-17 00:09:00 +10:00
2021-06-20 21:58:57 +10:00
2021-04-14 23:04:44 +10:00
2021-04-20 14:22:24 +10:00
2021-04-30 11:20:40 -07:00
2021-08-10 23:14:59 +10:00
2021-08-10 23:15:02 +10:00
2021-08-10 23:15:02 +10:00
2021-02-09 00:10:50 +11:00