Eric Biggers 9bd2bbc01d
elevator: fix truncation of icq_cache_name ...
gcc 7.1 reports the following warning:
block/elevator.c: In function ‘elv_register’:
block/elevator.c:898:5: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
"%s_io_cq", e->elevator_name);
^~~~~~~~~~
block/elevator.c:897:3: note: ‘snprintf’ output between 7 and 22 bytes into a destination of size 21
snprintf(e->icq_cache_name, sizeof(e->icq_cache_name),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s_io_cq", e->elevator_name);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The bug is that the name of the icq_cache is 6 characters longer than
the elevator name, but only ELV_NAME_MAX + 5 characters were reserved
for it --- so in the case of a maximum-length elevator name, the 'q'
character in "_io_cq" would be truncated by snprintf(). Fix it by
reserving ELV_NAME_MAX + 6 characters instead.
Signed-off-by: Eric Biggers <ebiggers@google.com >
Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com >
Signed-off-by: Jens Axboe <axboe@fb.com >
2017-06-06 11:20:47 -06:00
2017-05-04 16:08:52 +05:30
2017-05-08 17:15:13 -07:00
2017-04-25 09:04:29 +02:00
2017-05-23 20:32:10 +02:00
2017-05-22 10:39:11 +02:00
2017-05-02 11:02:41 +02:00
2017-05-09 12:51:49 +02:00
2017-04-21 10:45:01 -04:00
2017-05-08 19:03:25 -07:00
2017-05-08 17:15:13 -07:00
2017-05-24 15:43:57 -04:00
2017-04-24 21:49:15 +02:00
2017-05-11 10:44:22 -07:00
2017-05-15 12:51:38 +02:00
2017-05-16 10:24:27 +02:00
2017-05-22 10:39:10 +02:00
2017-05-11 11:12:26 -07:00
2017-05-01 12:37:29 +02:00
2017-05-04 12:31:02 -04:00
2017-04-30 22:17:36 +09:00
2017-05-08 17:15:15 -07:00
2017-05-10 15:33:45 +02:00
2017-04-26 15:58:22 +01:00
2017-05-16 16:16:30 -04:00
2017-05-23 11:01:28 -04:00
2017-05-09 15:15:47 -07:00
2017-05-09 15:15:47 -07:00
2017-04-28 18:09:59 -04:00
2017-05-02 10:16:05 -04:00
2017-04-20 12:09:55 -06:00
2017-04-20 12:09:55 -06:00
2017-05-01 14:09:21 -07:00
2017-05-22 20:50:11 +02:00
2017-05-12 15:43:10 -07:00
2017-05-11 14:19:00 -04:00
2017-04-26 23:54:06 -04:00
2017-05-01 13:52:24 -07:00
2017-05-01 16:15:18 -07:00
2017-04-20 14:56:58 +02:00
2017-04-20 12:09:55 -06:00
2017-05-03 08:50:52 -07:00
2017-05-08 17:15:11 -07:00
2017-05-08 17:15:11 -07:00
2017-05-13 17:52:16 -07:00
2017-05-05 15:54:45 +08:00
2017-05-05 18:49:20 -07:00
2017-04-26 23:57:53 +02:00
2017-04-20 13:47:46 +05:30
2017-05-04 18:06:17 +02:00
2017-04-20 16:31:06 +02:00
2017-06-06 11:20:47 -06:00
2017-05-08 17:15:11 -07:00
2017-05-03 10:04:56 -07:00
2017-04-27 05:13:04 -04:00
2017-05-25 13:44:28 -04:00
2017-05-12 15:57:15 -07:00
2017-04-30 01:26:34 -04:00
2017-05-04 11:44:37 -04:00
2017-05-04 11:44:41 -04:00
2017-05-08 17:15:13 -07:00
2017-04-21 14:17:27 -06:00
2017-05-03 15:52:10 -07:00
Merge branches 'for-4.11/upstream-fixes', 'for-4.12/accutouch', 'for-4.12/cp2112', 'for-4.12/hid-core-null-state-handling', 'for-4.12/hiddev', 'for-4.12/i2c-hid', 'for-4.12/innomedia', 'for-4.12/logitech-hidpp-battery-power-supply', 'for-4.12/multitouch', 'for-4.12/nti', 'for-4.12/upstream' and 'for-4.12/wacom' into for-linus
2017-05-02 11:01:10 +02:00
2017-05-04 19:15:35 -07:00
2017-05-03 12:38:20 -07:00
2017-04-20 12:16:10 -06:00
2017-04-28 12:28:45 +02:00
2017-04-27 16:34:29 -04:00
2017-05-24 16:27:14 -04:00
2017-05-03 08:50:52 -07:00
2017-04-19 13:58:51 -05:00
2017-04-25 13:20:46 -07:00
2017-05-04 18:06:17 +02:00
2017-05-08 17:15:12 -07:00
2017-05-03 15:52:09 -07:00
2017-05-08 17:15:10 -07:00
2017-04-23 15:51:26 +09:00
2017-05-02 15:53:46 -07:00
2017-05-08 17:15:11 -07:00
2017-05-17 21:50:27 -04:00
2017-05-08 17:15:14 -07:00
2017-05-03 15:52:10 -07:00
2017-05-10 11:29:23 -07:00
2017-04-19 20:27:50 +02:00
2017-05-04 14:01:24 -07:00
2017-05-03 15:52:11 -07:00
2017-05-03 15:52:10 -07:00
2017-05-08 17:15:13 -07:00
2017-05-08 17:15:10 -07:00
2017-05-23 10:04:41 +02:00
2017-05-03 19:12:27 -07:00
2017-04-24 14:30:46 -04:00
2017-04-21 14:05:36 -04:00
2017-05-10 21:46:22 -07:00
2017-05-11 21:30:57 -04:00
2017-05-03 09:51:24 -04:00
2017-05-10 13:03:38 -07:00
2017-04-26 13:03:04 -04:00
2017-04-21 10:45:01 -04:00
2017-05-08 19:01:06 -04:00
2017-05-20 10:11:34 -06:00
2017-04-21 16:41:47 +02:00
2017-05-09 15:15:47 -07:00
2017-05-09 22:55:58 +10:00
2017-05-11 10:26:22 -05:00
2017-05-22 18:01:46 +02:00
2017-05-05 11:36:44 -07:00
2017-05-08 17:15:10 -07:00
2017-04-28 10:23:19 -05:00
2017-05-26 10:51:18 -07:00
2017-04-26 22:39:08 -04:00
2017-05-09 10:01:15 -07:00
2017-05-05 22:54:28 +02:00
2017-04-25 13:20:46 -07:00
2017-05-08 17:15:11 -07:00
2017-05-08 17:15:12 -07:00
2017-05-09 16:43:23 +03:00
2017-05-23 07:40:44 -05:00
2017-05-02 06:29:22 -07:00
2017-04-19 09:29:18 -07:00
2017-05-10 10:30:46 -07:00
2017-04-21 05:59:27 -07:00
2017-04-21 05:59:27 -07:00
2017-05-01 16:22:40 -04:00
2017-05-01 10:26:40 -04:00
2017-05-03 15:52:10 -07:00
2017-05-03 15:52:09 -07:00
2017-05-05 18:16:23 -07:00
2017-05-08 17:15:12 -07:00
2017-05-18 17:38:24 +02:00
2017-05-02 16:40:27 -07:00
2017-04-26 11:23:28 -07:00
2017-04-26 11:23:28 -07:00
2017-04-26 16:32:17 -07:00
2017-05-05 18:49:20 -07:00
2017-05-05 22:54:28 +02:00
2017-05-03 15:52:11 -07:00
2017-04-26 14:44:39 -04:00
2017-05-02 10:45:15 -07:00
2017-05-08 17:15:15 -07:00
2017-05-18 17:38:24 +02:00
2017-04-19 09:29:17 -07:00
2017-05-08 17:15:14 -07:00
2017-05-02 23:41:43 +03:00
2017-05-02 23:41:43 +03:00
2017-04-24 12:35:56 -04:00
2017-05-09 16:43:22 +03:00
2017-05-03 15:52:08 -07:00
2017-05-12 15:57:15 -07:00
9bd2bbc01d