Vasily Averin
fc40fdefd9
netfilter: ctnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo
commit c23a9fd209 upstream.
Two patches listed below removed ctnetlink_dump_helpinfo call from under
rcu_read_lock. Now its rcu_dereference generates following warning:
=============================
WARNING: suspicious RCU usage
5.13.0+ #5 Not tainted
-----------------------------
net/netfilter/nf_conntrack_netlink.c:221 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
stack backtrace:
CPU: 1 PID: 2251 Comm: conntrack Not tainted 5.13.0+ #5
Call Trace:
dump_stack+0x7f/0xa1
ctnetlink_dump_helpinfo+0x134/0x150 [nf_conntrack_netlink]
ctnetlink_fill_info+0x2c2/0x390 [nf_conntrack_netlink]
ctnetlink_dump_table+0x13f/0x370 [nf_conntrack_netlink]
netlink_dump+0x10c/0x370
__netlink_dump_start+0x1a7/0x260
ctnetlink_get_conntrack+0x1e5/0x250 [nf_conntrack_netlink]
nfnetlink_rcv_msg+0x613/0x993 [nfnetlink]
netlink_rcv_skb+0x50/0x100
nfnetlink_rcv+0x55/0x120 [nfnetlink]
netlink_unicast+0x181/0x260
netlink_sendmsg+0x23f/0x460
sock_sendmsg+0x5b/0x60
__sys_sendto+0xf1/0x160
__x64_sys_sendto+0x24/0x30
do_syscall_64+0x36/0x70
entry_SYSCALL_64_after_hwframe+0x44/0xae
Fixes: 49ca022bcc ("netfilter: ctnetlink: don't dump ct extensions of unconfirmed conntracks")
Fixes: 0b35f6031a ("netfilter: Remove duplicated rcu_read_lock.")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-25 14:36:19 +02:00
..
2021-01-19 18:27:23 +01:00
2021-06-10 13:39:15 +02:00
2020-10-12 01:57:34 +02:00
2020-10-15 11:45:19 -07:00
2020-04-09 00:12:48 +09:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2019-07-16 13:16:59 +02:00
2019-07-16 13:16:59 +02:00
2021-02-17 11:02:26 +01:00
2019-10-26 12:36:42 +02:00
2019-09-13 12:33:06 +02:00
2019-12-17 22:59:31 +01:00
2020-07-16 12:35:15 -07:00
2020-07-22 01:18:05 +02:00
2019-07-16 13:16:59 +02:00
2019-06-19 17:09:52 +02:00
2019-09-13 12:33:06 +02:00
2019-07-16 13:16:59 +02:00
2019-08-27 18:07:03 +02:00
2019-05-30 11:26:32 -07:00
2021-07-25 14:36:19 +02:00
2020-08-28 20:11:38 +02:00
2020-01-08 23:31:22 +01:00
2019-06-19 17:09:55 +02:00
2021-04-10 13:36:08 +02:00
2020-05-27 22:20:34 +02:00
2020-05-27 22:20:34 +02:00
2020-08-20 14:13:49 +02:00
2020-10-20 13:54:53 +02:00
2020-08-29 13:03:06 +02:00
2021-06-10 13:39:13 +02:00
2019-07-16 13:16:59 +02:00
2019-05-31 18:02:45 +02:00
2019-07-16 13:16:59 +02:00
2019-05-30 11:26:32 -07:00
2021-05-07 11:04:31 +02:00
2019-07-16 13:16:59 +02:00
2019-09-13 12:33:06 +02:00
2019-05-24 17:37:51 +02:00
2020-10-22 14:49:36 +02:00
2021-06-03 09:00:37 +02:00
2020-06-25 00:50:31 +02:00
2020-10-12 01:58:10 +02:00
2021-06-03 09:00:37 +02:00
2020-05-27 22:20:34 +02:00
2020-10-14 01:25:14 +02:00
2019-06-19 17:09:55 +02:00
2020-04-27 02:07:40 -04:00
2019-07-16 13:16:59 +02:00
2021-01-19 18:27:33 +01:00
2019-07-16 13:16:59 +02:00
2019-06-22 08:59:24 -04:00
2019-07-16 13:16:59 +02:00
2019-04-11 20:59:34 +02:00
2021-03-17 17:06:12 +01:00
2019-06-22 08:59:24 -04:00
2019-07-16 13:16:59 +02:00
2019-07-16 13:16:59 +02:00
2020-03-29 16:28:29 +02:00
2020-07-24 15:41:54 -07:00
2021-06-23 14:42:43 +02:00
2021-06-10 13:39:29 +02:00
2020-10-04 21:08:33 +02:00
2021-07-14 16:56:24 +02:00
2019-06-19 17:09:55 +02:00
2020-07-29 20:09:18 +02:00
2021-06-10 13:39:19 +02:00
2020-07-22 01:18:05 +02:00
2020-08-28 20:11:58 +02:00
2021-05-19 10:13:08 +02:00
2020-08-28 20:11:58 +02:00
2020-10-30 12:57:39 +01:00
2020-10-04 21:08:33 +02:00
2019-08-26 11:01:00 +02:00
2020-10-12 01:57:34 +02:00
2020-03-06 18:00:43 +01:00
2020-10-30 12:57:39 +01:00
2021-05-14 09:50:40 +02:00
2020-08-10 13:03:36 +02:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2021-06-10 13:39:18 +02:00
2020-06-25 00:50:31 +02:00
2021-02-03 23:28:44 +01:00
2021-07-14 16:56:22 +02:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2020-07-22 01:18:05 +02:00
2020-08-29 13:03:06 +02:00
2020-10-22 14:49:36 +02:00
2020-06-25 00:50:31 +02:00
2020-07-15 20:15:19 +02:00
2021-04-21 13:00:56 +02:00
2020-06-25 00:50:31 +02:00
2020-04-05 23:26:36 +02:00
2020-06-25 00:50:31 +02:00
2020-11-27 12:10:47 +01:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2021-07-14 16:56:22 +02:00
2021-05-14 09:50:40 +02:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2019-12-09 13:14:03 +01:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2020-06-30 18:21:02 +02:00
2019-06-19 17:09:55 +02:00
2020-04-05 23:26:36 +02:00
2021-05-19 10:13:09 +02:00
2021-06-03 09:00:28 +02:00
2020-04-09 00:12:48 +09:00
2021-06-03 09:00:28 +02:00
2021-06-03 09:00:28 +02:00
2020-08-21 17:37:36 +02:00
2020-08-29 13:04:44 +02:00
2020-06-25 00:50:31 +02:00
2021-07-14 16:56:22 +02:00
2020-06-25 00:50:31 +02:00
2019-06-19 17:09:55 +02:00
2020-10-30 12:57:39 +01:00
2021-04-16 11:43:21 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2019-09-13 12:33:06 +02:00
2020-07-29 20:09:18 +02:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-03-15 15:20:16 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2020-08-28 19:55:51 +02:00
2020-04-05 23:26:37 +02:00
2019-05-30 11:26:32 -07:00
2019-06-25 01:32:59 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:38 -07:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-06-25 00:50:31 +02:00
2019-06-19 17:09:55 +02:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 11:28:45 +02:00
2019-06-25 01:32:59 +02:00
2019-09-13 12:32:48 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2021-01-12 20:18:26 +01:00
2019-06-19 17:09:55 +02:00
2021-02-17 11:02:25 +01:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2021-05-19 10:13:06 +02:00
2019-08-13 12:14:26 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2019-06-22 08:59:24 -04:00
2019-05-21 10:50:45 +02:00
2019-05-21 11:28:40 +02:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00