Matteo Croce
ac18b128cf
reboot: fix overflow parsing reboot cpu number
commit df5b0ab3e0 upstream.
Limit the CPU number to num_possible_cpus(), because setting it to a
value lower than INT_MAX but higher than NR_CPUS produces the following
error on reboot and shutdown:
BUG: unable to handle page fault for address: ffffffff90ab1bb0
#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page
PGD 1c09067 P4D 1c09067 PUD 1c0a063 PMD 0
Oops: 0000 [#1] SMP
CPU: 1 PID: 1 Comm: systemd-shutdow Not tainted 5.9.0-rc8-kvm #110
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014
RIP: 0010:migrate_to_reboot_cpu+0xe/0x60
Code: ea ea 00 48 89 fa 48 c7 c7 30 57 f1 81 e9 fa ef ff ff 66 2e 0f 1f 84 00 00 00 00 00 53 8b 1d d5 ea ea 00 e8 14 33 fe ff 89 da <48> 0f a3 15 ea fc bd 00 48 89 d0 73 29 89 c2 c1 e8 06 65 48 8b 3c
RSP: 0018:ffffc90000013e08 EFLAGS: 00010246
RAX: ffff88801f0a0000 RBX: 0000000077359400 RCX: 0000000000000000
RDX: 0000000077359400 RSI: 0000000000000002 RDI: ffffffff81c199e0
RBP: ffffffff81c1e3c0 R08: ffff88801f41f000 R09: ffffffff81c1e348
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 00007f32bedf8830 R14: 00000000fee1dead R15: 0000000000000000
FS: 00007f32bedf8980(0000) GS:ffff88801f480000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffff90ab1bb0 CR3: 000000001d057000 CR4: 00000000000006a0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
__do_sys_reboot.cold+0x34/0x5b
do_syscall_64+0x2d/0x40
Fixes: 1b3a5d02ee ("reboot: move arch/x86 reboot= handling to generic kernel")
Signed-off-by: Matteo Croce <mcroce@microsoft.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Fabian Frederick <fabf@skynet.be>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Kees Cook <keescook@chromium.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Robin Holt <robinmholt@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lkml.kernel.org/r/20201103214025.116799-3-mcroce@linux.microsoft.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-11-18 19:20:30 +01:00
..
2020-11-18 19:20:26 +01:00
2020-07-22 09:32:49 +02:00
2020-11-05 11:43:16 +01:00
2020-04-29 16:33:00 +02:00
2020-11-18 19:20:28 +01:00
2020-09-17 13:47:56 +02:00
2020-11-18 19:20:16 +01:00
2019-08-19 13:03:37 +02:00
2020-10-01 13:17:33 +02:00
2020-10-29 09:58:04 +01:00
2020-10-01 13:18:04 +02:00
2020-03-05 16:43:50 +01:00
2020-10-29 09:58:00 +01:00
2020-11-18 19:20:26 +01:00
2020-11-18 19:20:23 +01:00
2020-10-01 13:17:32 +02:00
2020-06-22 09:30:59 +02:00
2020-06-22 09:30:59 +02:00
2020-06-22 09:30:59 +02:00
2020-06-22 09:31:22 +02:00
2020-06-22 09:31:01 +02:00
2020-01-17 19:48:42 +01:00
2019-09-25 17:51:39 -07:00
2020-06-22 09:31:01 +02:00
2019-08-21 22:23:48 +10:00
2020-11-10 12:37:32 +01:00
2019-10-06 09:11:37 -06:00
2020-11-18 19:20:30 +01:00
2020-09-03 11:27:10 +02:00
2019-08-29 15:10:10 +01:00
2020-07-16 08:16:44 +02:00
2020-10-01 13:17:48 +02:00
2019-09-25 17:51:40 -07:00
2019-09-06 23:58:44 +02:00
2019-09-28 08:14:15 -07:00
2019-08-19 21:54:15 -07:00
2020-04-17 10:50:22 +02:00
2020-10-01 13:18:25 +02:00
2020-11-10 12:37:27 +01:00
2020-10-01 13:17:10 +02:00
2019-08-05 18:39:56 -04:00
2019-08-05 18:39:56 -04:00
2020-10-29 09:57:55 +01:00
2020-10-01 13:17:23 +02:00
2020-06-17 16:40:22 +02:00
2019-10-07 15:47:19 -07:00
2019-08-19 21:54:16 -07:00
2020-01-23 08:22:36 +01:00
2020-11-18 19:20:30 +01:00
2020-08-26 10:40:51 +02:00
2020-06-24 17:50:35 +02:00
2020-11-05 11:43:23 +01:00
2020-11-10 12:37:24 +01:00
2019-11-04 21:19:25 +01:00
2019-10-17 12:47:12 +02:00
2020-10-01 13:17:23 +02:00
2020-10-01 13:17:10 +02:00
2020-01-04 19:18:32 +01:00
2020-01-09 10:19:54 +01:00
2020-10-14 10:32:58 +02:00
2020-02-24 08:36:52 +01:00
2020-10-01 13:17:54 +02:00