Eric Dumazet
4c9f207810
bonding: fix data-races around agg_select_timer
commit 9ceaf6f76b203682bb6100e14b3d7da4c0bedde8 upstream.
syzbot reported that two threads might write over agg_select_timer
at the same time. Make agg_select_timer atomic to fix the races.
BUG: KCSAN: data-race in bond_3ad_initiate_agg_selection / bond_3ad_state_machine_handler
read to 0xffff8881242aea90 of 4 bytes by task 1846 on cpu 1:
bond_3ad_state_machine_handler+0x99/0x2810 drivers/net/bonding/bond_3ad.c:2317
process_one_work+0x3f6/0x960 kernel/workqueue.c:2307
worker_thread+0x616/0xa70 kernel/workqueue.c:2454
kthread+0x1bf/0x1e0 kernel/kthread.c:377
ret_from_fork+0x1f/0x30
write to 0xffff8881242aea90 of 4 bytes by task 25910 on cpu 0:
bond_3ad_initiate_agg_selection+0x18/0x30 drivers/net/bonding/bond_3ad.c:1998
bond_open+0x658/0x6f0 drivers/net/bonding/bond_main.c:3967
__dev_open+0x274/0x3a0 net/core/dev.c:1407
dev_open+0x54/0x190 net/core/dev.c:1443
bond_enslave+0xcef/0x3000 drivers/net/bonding/bond_main.c:1937
do_set_master net/core/rtnetlink.c:2532 [inline]
do_setlink+0x94f/0x2500 net/core/rtnetlink.c:2736
__rtnl_newlink net/core/rtnetlink.c:3414 [inline]
rtnl_newlink+0xfeb/0x13e0 net/core/rtnetlink.c:3529
rtnetlink_rcv_msg+0x745/0x7e0 net/core/rtnetlink.c:5594
netlink_rcv_skb+0x14e/0x250 net/netlink/af_netlink.c:2494
rtnetlink_rcv+0x18/0x20 net/core/rtnetlink.c:5612
netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline]
netlink_unicast+0x602/0x6d0 net/netlink/af_netlink.c:1343
netlink_sendmsg+0x728/0x850 net/netlink/af_netlink.c:1919
sock_sendmsg_nosec net/socket.c:705 [inline]
sock_sendmsg net/socket.c:725 [inline]
____sys_sendmsg+0x39a/0x510 net/socket.c:2413
___sys_sendmsg net/socket.c:2467 [inline]
__sys_sendmsg+0x195/0x230 net/socket.c:2496
__do_sys_sendmsg net/socket.c:2505 [inline]
__se_sys_sendmsg net/socket.c:2503 [inline]
__x64_sys_sendmsg+0x42/0x50 net/socket.c:2503
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
value changed: 0x00000050 -> 0x0000004f
Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 25910 Comm: syz-executor.1 Tainted: G W 5.17.0-rc4-syzkaller-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: Jay Vosburgh <j.vosburgh@gmail.com>
Cc: Veaceslav Falico <vfalico@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-02-23 12:03:12 +01:00
..
2020-11-19 17:21:34 +01:00
2022-01-16 09:12:44 +01:00
2021-07-01 13:19:48 -07:00
2021-01-28 20:36:21 -08:00
2021-12-14 10:57:10 +01:00
2022-02-23 12:03:10 +01:00
2021-11-25 09:48:40 +01:00
2022-01-11 15:35:14 +01:00
2021-06-01 16:54:42 -07:00
2020-02-28 14:51:30 +01:00
2021-08-02 10:24:38 +01:00
2022-02-23 12:03:10 +01:00
2021-04-23 10:17:26 +01:00
2021-08-16 18:43:39 -07:00
2021-06-11 13:32:46 -07:00
2021-08-03 13:05:25 +01:00
2020-07-21 18:30:47 -07:00
2022-02-23 12:03:12 +01:00
2021-12-14 10:57:09 +01:00
2021-08-03 11:50:22 +01:00
2021-08-11 14:57:31 -07:00
2021-03-26 17:43:55 +01:00
2021-07-01 11:23:50 -07:00
2021-10-25 15:20:22 +02:00
2020-02-29 14:39:08 +01:00
2021-06-10 11:45:14 -04:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2021-08-05 11:46:42 +01:00
2021-08-14 13:59:10 +01:00
2021-07-30 15:33:24 +02:00
2022-02-23 12:03:11 +01:00
2021-12-08 09:04:46 +01:00
2022-02-16 12:56:30 +01:00
2020-05-08 21:33:33 -07:00
2021-07-29 12:18:11 +01:00
2020-05-05 13:23:29 -07:00
2020-04-20 07:34:16 +02:00
2021-12-08 09:04:43 +01:00
2021-03-14 14:46:32 -07:00
2021-08-19 18:09:18 -07:00
2021-09-02 11:44:19 +01:00
2021-01-21 13:33:45 +01:00
2021-01-21 13:33:45 +01:00
2021-02-12 16:31:46 -08:00
2021-01-29 20:39:14 -08:00
2021-03-18 19:51:12 -07:00
2020-06-22 21:12:44 -07:00
2021-06-28 14:29:45 -07:00
2021-08-13 09:58:25 +02:00
2021-08-27 17:29:18 -07:00
2020-03-30 13:45:04 -07:00
2021-01-27 18:18:15 -08:00
2021-11-18 19:16:33 +01:00
2020-12-14 18:38:58 -08:00
2022-01-27 11:05:35 +01:00
2021-07-23 16:44:57 -07:00
2021-12-29 12:28:42 +01:00
2021-07-21 08:14:33 -07:00
2020-06-20 17:47:53 -07:00
2022-02-23 12:03:10 +01:00
2021-08-05 15:08:47 -07:00
2021-12-08 09:04:49 +01:00
2021-07-27 20:11:44 +01:00
2021-02-04 18:37:57 -08:00
2022-02-01 17:27:08 +01:00
2022-01-27 11:05:35 +01:00
2021-12-01 09:04:49 +01:00
2022-02-23 12:03:10 +01:00
2020-06-20 17:22:22 -07:00
2021-03-23 14:14:50 -07:00
2021-07-27 13:05:56 +01:00
2021-11-18 19:17:10 +01:00
2021-08-30 01:51:36 +02:00
2021-09-27 12:02:54 +02:00
2021-06-24 12:41:12 -07:00
2021-10-18 13:47:09 +01:00
2021-08-25 11:23:14 +01:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2020-02-28 12:08:37 -08:00
2020-05-29 21:20:20 -07:00
2021-10-28 08:19:06 -07:00
2020-08-24 06:40:07 -07:00
2021-11-18 19:17:16 +01:00
2021-08-01 12:00:51 +02:00
2021-07-27 11:43:50 +01:00
2021-09-24 14:07:10 +01:00
2021-12-01 09:04:46 +01:00
2021-08-09 15:49:00 -07:00
2020-03-04 13:25:55 -08:00
2021-08-30 16:33:59 -07:00
2022-01-27 11:04:02 +01:00
2021-05-17 15:29:35 -07:00
2021-08-09 15:34:21 -07:00
2021-03-25 17:40:43 -07:00
2020-07-31 09:24:23 +02:00
2020-08-24 14:35:00 -07:00
2022-02-01 17:27:14 +01:00
2020-06-23 20:27:09 -07:00
2021-08-04 10:01:26 +01:00
2022-01-27 11:05:40 +01:00
2020-07-13 11:03:44 -07:00
2022-01-27 11:05:05 +01:00
2021-04-28 14:06:45 -07:00
2020-09-28 15:19:03 -07:00
2021-06-15 18:01:05 +02:00
2021-12-29 12:28:42 +01:00
2021-08-03 13:05:26 +01:00
2021-11-18 19:17:11 +01:00
2021-08-04 12:35:07 +01:00
2021-11-18 19:16:33 +01:00
2021-10-28 14:41:20 +01:00
2020-06-23 20:10:15 -07:00
2020-06-18 20:46:23 -07:00
2021-02-04 18:37:14 -08:00
2021-10-26 13:09:22 +01:00
2020-09-14 16:49:39 -07:00
2020-11-17 22:07:40 +01:00
2021-06-24 19:41:15 +02:00
2021-07-07 19:51:12 -07:00
2022-01-27 11:05:14 +01:00
2021-06-18 16:57:19 +02:00