Zechuan Chen 228a7024ed perf probe: Fix ppc64 'perf probe add events failed' case ...

commit 4624f199327a704dd1069aca1c3cadb8f2a28c6f upstream.

Because of commit bf794bf52a ("powerpc/kprobes: Fix kallsyms
lookup across powerpc ABIv1 and ABIv2"), in ppc64 ABIv1, our perf
command eliminates the need to use the prefix "." at the symbol name.

But when the command "perf probe -a schedule" is executed on ppc64
ABIv1, it obtains two symbol address information through /proc/kallsyms,
for example:

  cat /proc/kallsyms | grep -w schedule
  c000000000657020 T .schedule
  c000000000d4fdb8 D schedule

The symbol "D schedule" is not a function symbol, and perf will print:
"p:probe/schedule _text+13958584"Failed to write event: Invalid argument

Therefore, when searching symbols from map and adding probe point for
them, a symbol type check is added. If the type of symbol is not a
function, skip it.

Fixes: bf794bf52a ("powerpc/kprobes: Fix kallsyms lookup across powerpc ABIv1 and ABIv2")
Signed-off-by: Zechuan Chen <chenzechuan1@huawei.com>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jianlin Lv <Jianlin.Lv@arm.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Link: https://lore.kernel.org/r/20211228111338.218602-1-chenzechuan1@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2022-01-27 11:05:38 +01:00

..

arch

perf callchain: Fix compilation on powerpc with gcc11+

2021-10-31 12:51:41 -03:00

bench

perf bench futex: Fix memory leak of perf_cpu_map__new()

2021-11-25 09:48:33 +01:00

dlfilters

perf tests: Add dlfilter test

2021-08-11 09:35:44 -03:00

Documentation

perf doc: Fix typos all over the place

2021-09-27 09:32:28 -03:00

examples/bpf

…

include

perf build: Move perf_dlfilters.h in the source tree

2021-08-11 09:35:24 -03:00

jvmti

…

pmu-events

perf jevents: Free the sys_event_tables list after processing entries

2021-10-05 14:48:10 -03:00

python

…

scripts

perf scripts python: intel-pt-events.py: Fix printing of switch events

2022-01-05 12:42:40 +01:00

tests

perf tests: Remove bash construct from record+zstd_comp_decomp.sh

2021-11-25 09:48:33 +01:00

trace

perf beauty: Cover more flags in the move_mount syscall argument beautifier

2021-09-10 18:15:22 -03:00

ui

perf annotate: Avoid TUI crash when navigating in the annotation of recursive functions

2022-01-20 09:13:15 +01:00

util

perf probe: Fix ppc64 'perf probe add events failed' case

2022-01-27 11:05:38 +01:00

.gitignore

perf tools: Ignore Documentation dependency file

2021-09-11 15:36:16 -03:00

Build

…

builtin-annotate.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-bench.c

perf bench: Add benchmark for evlist open/close operations

2021-08-10 11:32:37 -03:00

builtin-buildid-cache.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-buildid-list.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-c2c.c

Merge branch 'akpm' (patches from Andrew)

2021-09-08 12:55:35 -07:00

builtin-config.c

…

builtin-daemon.c

…

builtin-data.c

perf data: Correct -h output

2021-08-31 15:12:00 -03:00

builtin-diff.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-evlist.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-ftrace.c

…

builtin-help.c

…

builtin-inject.c

perf inject: Fix segfault due to perf_data__fd() without open

2021-12-22 09:32:48 +01:00

builtin-kallsyms.c

…

builtin-kmem.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-kvm.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-list.c

…

builtin-lock.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-mem.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-probe.c

…

builtin-record.c

Merge branch 'akpm' (patches from Andrew)

2021-09-08 12:55:35 -07:00

builtin-report.c

perf report: Fix memory leaks around perf_tip()

2021-12-08 09:04:41 +01:00

builtin-sched.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-script.c

perf script: Fix CPU filtering of a script's switch events

2022-01-05 12:42:39 +01:00

builtin-stat.c

perf iostat: Use system-wide mode if the target cpu_list is unspecified

2021-09-27 09:39:30 -03:00

builtin-timechart.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-top.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-trace.c

perf tools: Remove repipe argument from perf_session__new()

2021-08-02 10:06:51 -03:00

builtin-version.c

…

builtin.h

…

check-headers.sh

perf report: Add tools/arch/x86/include/asm/amd-ibs.h

2021-09-10 18:13:20 -03:00

command-list.txt

…

CREDITS

…

design.txt

…

Makefile

…

Makefile.config

perf tools: Drop requirement for libstdc++.so for libopencsd check

2022-01-27 11:05:38 +01:00

Makefile.perf

perf build: Suppress 'rm dlfilter' build message

2021-10-31 12:51:41 -03:00

MANIFEST

…

perf-archive.sh

…

perf-completion.sh

…

perf-iostat.sh

…

perf-read-vdso.c

…

perf-sys.h

…

perf-with-kcore.sh

…

perf.c

…

perf.h

…