Files
kernel_arpi/include/uapi/linux
Damien Le Moal ba05200fcc block: fix IOPRIO_PRIO_CLASS() and IOPRIO_PRIO_VALUE() macros
The ki_ioprio field of struct kiocb is 16-bits (u16) but often handled
as an int in the block layer. E.g. ioprio_check_cap() takes an int as
argument.

With such implicit int casting function calls, the upper 16-bits of the
int argument may be left uninitialized by the compiler, resulting in
invalid values for the IOPRIO_PRIO_CLASS() macro (garbage upper bits)
and in an error return for functions such as ioprio_check_cap().

Fix this by masking the result of the shift by IOPRIO_CLASS_SHIFT bits
in the IOPRIO_PRIO_CLASS() macro. The new macro IOPRIO_CLASS_MASK
defines the 3-bits mask for the priority class.
Similarly, apply the IOPRIO_PRIO_MASK mask to the data argument of the
IOPRIO_PRIO_VALUE() macro to ignore the upper bits of the data value.
The IOPRIO_CLASS_MASK mask is also applied to the class argument of this
macro before shifting the result by IOPRIO_CLASS_SHIFT bits.

While at it, also change the argument name of the IOPRIO_PRIO_CLASS()
and IOPRIO_PRIO_DATA() macros from "mask" to "ioprio" to reflect the
fact that a priority value should be passed rather than a mask.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Link: https://lore.kernel.org/r/20210811033702.368488-5-damien.lemoal@wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2021-08-18 07:21:12 -06:00
..
2021-01-25 18:44:44 +01:00
2020-12-28 14:21:31 +00:00
2021-02-09 10:58:19 +01:00
2021-06-10 20:59:05 -04:00
2021-06-15 18:01:06 +02:00
2021-03-04 17:58:15 -08:00
2021-06-22 14:11:57 +02:00
2021-06-22 14:11:57 +02:00
2021-02-08 13:01:24 +01:00
2021-06-03 15:31:34 -07:00
2021-02-26 09:41:03 -08:00
2021-05-21 15:03:50 +02:00
2021-03-10 09:34:06 +01:00
2021-06-18 11:40:11 -07:00
2021-07-06 10:37:46 -05:00
2021-01-16 23:19:26 +01:00
2021-03-10 09:34:06 +01:00
2021-06-23 12:56:08 -07:00
2021-01-07 16:17:32 +01:00
2020-10-23 11:55:28 -04:00
2020-10-23 11:55:28 -04:00
2021-06-12 13:16:45 -07:00