Vivek Goyal
2b5e027657
virtiofs: schedule blocking async replies in separate worker
...
[ Upstream commit bb737bbe48 ]
In virtiofs (unlike in regular fuse) processing of async replies is
serialized. This can result in a deadlock in rare corner cases when
there's a circular dependency between the completion of two or more async
replies.
Such a deadlock can be reproduced with xfstests:generic/503 if TEST_DIR ==
SCRATCH_MNT (which is a misconfiguration):
- Process A is waiting for page lock in worker thread context and blocked
(virtio_fs_requests_done_work()).
- Process B is holding page lock and waiting for pending writes to
finish (fuse_wait_on_page_writeback()).
- Write requests are waiting in virtqueue and can't complete because
worker thread is blocked on page lock (process A).
Fix this by creating a unique work_struct for each async reply that can
block (O_DIRECT read).
Fixes: a62a8ef9d9 ("virtio-fs: add virtiofs filesystem")
Signed-off-by: Vivek Goyal <vgoyal@redhat.com >
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2020-06-24 17:50:21 +02:00
..
2019-09-27 15:10:34 -07:00
2019-07-19 11:33:22 -07:00
2020-01-17 19:48:50 +01:00
2020-05-27 17:46:48 +02:00
2019-10-25 00:03:11 -04:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2020-06-22 09:31:13 +02:00
2020-06-03 08:21:11 +02:00
2020-06-03 08:21:25 +02:00
2020-06-24 17:50:18 +02:00
2019-09-19 09:42:37 -07:00
2020-05-27 17:46:30 +02:00
2019-11-23 21:44:49 -05:00
2020-03-18 07:17:53 +01:00
2020-04-17 10:50:02 +02:00
2019-09-03 09:30:56 -04:00
2019-07-12 17:37:53 -07:00
2020-02-28 17:22:26 +01:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:17 -07:00
2020-04-17 10:50:16 +02:00
2019-11-10 11:56:05 -05:00
2020-04-23 10:36:41 +02:00
2020-06-22 09:31:16 +02:00
2020-06-24 17:50:19 +02:00
2020-06-17 16:40:36 +02:00
2019-08-30 07:27:17 -07:00
2020-06-24 17:50:21 +02:00
2020-06-17 16:40:21 +02:00
2020-04-17 10:50:22 +02:00
2019-08-30 08:11:25 -07:00
2020-01-04 19:19:19 +01:00
2020-01-04 19:17:31 +01:00
2019-09-19 09:42:37 -07:00
2020-04-21 09:04:52 +02:00
2019-12-04 22:31:06 +01:00
2019-09-19 09:42:37 -07:00
2019-12-13 08:42:53 +01:00
2019-08-30 07:27:17 -07:00
2020-05-20 08:20:27 +02:00
2020-06-24 17:50:17 +02:00
2020-06-17 16:40:29 +02:00
2020-06-17 16:40:24 +02:00
2020-02-11 04:35:12 -08:00
2020-05-06 08:15:09 +02:00
2019-08-30 08:11:25 -07:00
2019-07-19 10:42:02 -07:00
2020-02-24 08:37:02 +01:00
2020-06-17 16:40:32 +02:00
2020-06-17 16:40:33 +02:00
2020-04-17 10:50:12 +02:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2020-01-12 12:21:37 +01:00
2019-09-12 21:05:34 -04:00
2020-02-24 08:37:00 +01:00
2019-09-19 10:06:57 -07:00
2019-09-19 10:06:57 -07:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:18 -07:00
2019-10-12 20:49:07 -04:00
2020-05-27 17:46:14 +02:00
2020-02-24 08:36:44 +01:00
2019-09-19 09:42:37 -07:00
2019-09-17 11:48:24 -04:00
2019-08-12 19:33:50 -07:00
2020-06-22 09:31:03 +02:00
2020-06-17 16:40:24 +02:00
2019-07-19 10:42:02 -07:00
2020-02-11 04:35:12 -08:00
2020-06-03 08:21:27 +02:00
2019-07-16 19:23:22 -07:00
2019-07-19 10:42:02 -07:00
2020-04-23 10:36:34 +02:00
2020-04-23 10:36:15 +02:00
2020-01-14 20:08:18 +01:00
2020-01-09 10:20:05 +01:00
2020-05-14 07:58:27 +02:00
2019-08-30 19:31:09 -04:00
2020-03-05 16:43:36 +01:00
2019-07-20 09:15:51 -07:00
2019-10-14 15:04:01 -07:00
2020-01-12 12:21:37 +01:00
2020-02-11 04:35:37 -08:00
2020-05-14 07:58:26 +02:00
2020-05-20 08:20:34 +02:00
2019-08-07 21:51:47 -04:00
2019-08-19 11:00:39 -04:00
2020-05-27 17:46:12 +02:00
2020-04-17 10:50:21 +02:00
2019-09-06 21:28:49 +02:00
2019-09-12 21:06:14 -04:00
2019-07-16 22:52:37 -04:00
2020-02-11 04:35:11 -08:00
2019-07-19 10:42:02 -07:00
2020-03-25 08:25:58 +01:00
2020-01-17 19:48:21 +01:00
2020-06-17 16:40:26 +02:00
2019-12-17 19:55:30 +01:00
2019-09-18 16:59:14 -07:00
2020-04-01 11:02:17 +02:00
2020-03-25 08:25:41 +01:00
2019-09-18 16:59:14 -07:00
2019-07-16 22:52:37 -04:00
2020-01-17 19:48:21 +01:00
2020-03-05 16:43:48 +01:00
2019-10-16 23:15:09 -04:00
2020-03-18 07:17:51 +01:00
2020-05-02 08:48:44 +02:00
2019-09-06 21:28:49 +02:00
2020-02-11 04:35:23 -08:00
2020-01-29 16:45:31 +01:00
2019-07-16 19:23:25 -07:00
2019-08-13 16:06:52 -07:00
2019-12-17 19:56:52 +01:00
2019-10-03 14:21:35 -07:00
2020-05-06 08:15:15 +02:00
2019-08-01 20:51:23 +02:00
2020-01-04 19:18:32 +01:00
2020-02-11 04:35:12 -08:00