Files
kernel_arpi/include/linux
Paul Cercueil 1b399bb048 kconfig.h: Add IF_ENABLED() macro
IF_ENABLED(CONFIG_FOO, ptr) evaluates to (ptr) if CONFIG_FOO is set to 'y'
or 'm', NULL otherwise. The (ptr) argument must be a pointer.

The IF_ENABLED() macro can be very useful to help GCC drop dead code.

For instance, consider the following:

    #ifdef CONFIG_FOO_SUSPEND
    static int foo_suspend(struct device *dev)
    {
       ...
    }
    #endif

    static struct pm_ops foo_ops = {
	#ifdef CONFIG_FOO_SUSPEND
        .suspend = foo_suspend,
	#endif
    };

While this works, the foo_suspend() macro is compiled conditionally,
only when CONFIG_FOO_SUSPEND is set. This is problematic, as there could
be a build bug in this function, we wouldn't have a way to know unless
the config option is set.

An alternative is to declare foo_suspend() always, but mark it as maybe
unused:

    static int __maybe_unused foo_suspend(struct device *dev)
    {
       ...
    }

    static struct pm_ops foo_ops = {
	#ifdef CONFIG_FOO_SUSPEND
        .suspend = foo_suspend,
	#endif
    };

Again, this works, but the __maybe_unused attribute is required to
instruct the compiler that the function may not be referenced anywhere,
and is safe to remove without making a fuss about it. This makes the
programmer responsible for tagging the functions that can be
garbage-collected.

With this patch, it is now possible to write the following:

    static int foo_suspend(struct device *dev)
    {
       ...
    }

    static struct pm_ops foo_ops = {
        .suspend = IF_ENABLED(CONFIG_FOO_SUSPEND, foo_suspend),
    };

The foo_suspend() function will now be automatically dropped by the
compiler, and it does not require any specific attribute.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20201213235447.138271-1-paul@crapouillou.net
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2021-01-18 16:13:51 +01:00
..
2020-12-09 19:26:02 -06:00
2020-12-02 09:46:55 -07:00
2020-12-02 09:46:55 -07:00
2020-12-19 11:18:38 -08:00
2020-12-14 16:24:19 +01:00
2020-12-11 14:02:14 -08:00
2020-12-02 22:00:22 -08:00
2020-12-10 12:42:59 -06:00
2020-12-02 22:10:35 -08:00
2020-11-23 14:16:55 +00:00
2020-12-08 14:14:48 +00:00
2020-11-24 16:47:48 +01:00
2020-12-15 16:19:31 +01:00
2021-01-18 16:13:51 +01:00
2020-12-15 16:19:31 +01:00
2020-12-07 10:29:57 +01:00
2020-12-04 12:23:25 +01:00
2020-12-15 15:11:08 -06:00
2020-12-16 13:08:18 -08:00
2020-12-03 11:20:52 +01:00
2020-12-15 12:13:39 -08:00
2020-12-07 17:12:49 -07:00
2020-12-10 16:17:15 +01:00
2020-12-15 12:13:37 -08:00
2020-11-24 16:47:49 +01:00
2020-12-10 10:45:36 +01:00
2020-12-19 11:18:38 -08:00
2020-12-04 16:54:35 +01:00
2020-12-15 12:13:41 -08:00