Yintian Tao
d2790e10d3
drm/amdgpu: no need to clean debugfs at amdgpu
drm_minor_unregister will invoke drm_debugfs_cleanup
to clean all the child node under primary minor node.
We don't need to invoke amdgpu_debugfs_fini and
amdgpu_debugfs_regs_cleanup to clean agian.
Otherwise, it will raise the NULL pointer like below.
[ 45.046029] BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8
[ 45.047256] PGD 0 P4D 0
[ 45.047713] Oops: 0002 [#1] SMP PTI
[ 45.048198] CPU: 0 PID: 2796 Comm: modprobe Tainted: G W OE 4.18.0-15-generic #16~18.04.1-Ubuntu
[ 45.049538] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
[ 45.050651] RIP: 0010:down_write+0x1f/0x40
[ 45.051194] Code: 90 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 48 89 e5 53 48 89 fb e8 ce d9 ff ff 48 ba 01 00 00 00 ff ff ff ff 48 89 d8 <f0> 48 0f c1 10 85 d2 74 05 e8 53 1c ff ff 65 48 8b 04 25 00 5c 01
[ 45.053702] RSP: 0018:ffffad8f4133fd40 EFLAGS: 00010246
[ 45.054384] RAX: 00000000000000a8 RBX: 00000000000000a8 RCX: ffffa011327dd814
[ 45.055349] RDX: ffffffff00000001 RSI: 0000000000000001 RDI: 00000000000000a8
[ 45.056346] RBP: ffffad8f4133fd48 R08: 0000000000000000 R09: ffffffffc0690a00
[ 45.057326] R10: ffffad8f4133fd58 R11: 0000000000000001 R12: ffffa0113cff0300
[ 45.058266] R13: ffffa0113c0a0000 R14: ffffffffc0c02a10 R15: ffffa0113e5c7860
[ 45.059221] FS: 00007f60d46f9540(0000) GS:ffffa0113fc00000(0000) knlGS:0000000000000000
[ 45.060809] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 45.061826] CR2: 00000000000000a8 CR3: 0000000136250004 CR4: 00000000003606f0
[ 45.062913] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 45.064404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 45.065897] Call Trace:
[ 45.066426] debugfs_remove+0x36/0xa0
[ 45.067131] amdgpu_debugfs_ring_fini+0x15/0x20 [amdgpu]
[ 45.068019] amdgpu_debugfs_fini+0x2c/0x50 [amdgpu]
[ 45.068756] amdgpu_pci_remove+0x49/0x70 [amdgpu]
[ 45.069439] pci_device_remove+0x3e/0xc0
[ 45.070037] device_release_driver_internal+0x18a/0x260
[ 45.070842] driver_detach+0x3f/0x80
[ 45.071325] bus_remove_driver+0x59/0xd0
[ 45.071850] driver_unregister+0x2c/0x40
[ 45.072377] pci_unregister_driver+0x22/0xa0
[ 45.073043] amdgpu_exit+0x15/0x57c [amdgpu]
[ 45.073683] __x64_sys_delete_module+0x146/0x280
[ 45.074369] do_syscall_64+0x5a/0x120
[ 45.074916] entry_SYSCALL_64_after_hwframe+0x44/0xa9
v2: remove all debugfs cleanup/fini code at amdgpu
v3: squash in unused variable removal
Signed-off-by: Yintian Tao <yttao@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-02-28 16:59:22 -05:00
..
2020-01-22 16:55:27 -05:00
2019-06-10 23:02:48 +02:00
2019-06-10 23:02:48 +02:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-02-26 14:20:05 -05:00
2020-02-28 16:59:20 -05:00
2019-12-23 14:59:20 -05:00
2019-12-23 14:59:20 -05:00
2019-12-23 14:59:20 -05:00
2020-01-07 11:55:56 -05:00
2019-11-06 16:27:48 -05:00
2019-06-10 23:02:48 +02:00
2019-10-17 17:12:34 -04:00
2019-05-24 12:21:02 -05:00
2019-06-10 23:02:48 +02:00
2020-02-26 14:21:13 -05:00
2020-02-04 23:30:39 -05:00
2019-10-25 11:40:50 +02:00
2020-01-30 17:15:42 -05:00
2020-01-30 17:15:42 -05:00
2020-02-28 16:59:22 -05:00
2020-02-28 16:59:22 -05:00
2020-02-28 16:59:22 -05:00
2020-01-22 16:34:07 -05:00
2020-02-25 11:01:25 -05:00
2019-10-17 16:31:06 -04:00
2020-02-17 10:34:34 +01:00
2019-07-30 23:48:32 -05:00
2019-12-17 13:57:54 +01:00
2019-10-28 16:59:43 +01:00
2019-07-18 14:18:05 -05:00
2020-02-26 14:17:32 -05:00
2020-02-26 14:17:32 -05:00
2020-02-28 16:59:22 -05:00
2019-10-03 09:11:05 -05:00
2019-12-05 10:57:42 +02:00
2020-02-26 14:21:12 -05:00
2019-11-13 15:29:44 -05:00
2019-08-12 12:47:47 -05:00
2019-11-04 09:28:51 +10:00
2019-09-16 09:59:21 -05:00
2020-02-26 14:17:33 -05:00
2020-02-28 16:59:20 -05:00
2020-01-07 12:03:47 -05:00
2020-02-25 11:01:26 -05:00
2019-06-10 23:02:48 +02:00
2019-06-10 23:02:48 +02:00
2020-02-26 14:21:12 -05:00
2019-12-09 17:02:07 -05:00
2019-08-13 09:09:30 +02:00
2019-11-19 10:12:54 -05:00
2019-06-10 23:02:48 +02:00
2019-11-19 12:09:23 -05:00
2020-01-16 13:35:10 -05:00
2020-01-16 13:35:10 -05:00
2019-11-19 10:12:50 -05:00
2019-12-18 16:09:12 -05:00
2020-02-28 15:40:26 +10:00
2019-06-21 18:59:28 -05:00
2019-10-03 09:11:02 -05:00
2019-10-03 09:11:02 -05:00
2019-11-23 19:56:45 -04:00
2019-11-23 19:56:45 -04:00
2020-02-13 13:08:13 +01:00
2019-10-03 09:11:02 -05:00
2019-10-15 15:49:14 -04:00
2020-02-26 14:17:32 -05:00
2020-02-26 14:21:12 -05:00
2019-06-10 23:02:48 +02:00
2020-02-26 14:21:12 -05:00
2020-02-26 14:21:12 -05:00
2020-02-11 15:35:54 -05:00
2019-06-20 11:36:22 -05:00
2020-02-26 14:17:32 -05:00
2020-02-26 14:17:32 -05:00
2020-02-26 14:17:32 -05:00
2019-11-26 12:20:22 -05:00
2020-02-26 14:17:32 -05:00
2019-12-18 16:09:06 -05:00
2020-02-28 16:59:22 -05:00
2020-02-26 14:21:12 -05:00
2019-12-03 11:57:00 -05:00
2020-02-28 16:59:21 -05:00
2019-06-10 23:02:48 +02:00
2019-06-10 22:59:53 +02:00
2019-06-10 23:00:08 +02:00
2020-02-25 11:01:25 -05:00
2020-01-14 10:18:08 -05:00
2019-06-21 18:59:34 -05:00
2020-02-04 23:30:39 -05:00
2020-02-04 23:30:39 -05:00
2019-11-06 16:27:48 -05:00
2019-06-10 23:02:48 +02:00
2019-11-22 14:55:12 -05:00
2020-02-28 16:59:22 -05:00
2020-02-28 16:59:22 -05:00
2019-11-13 15:29:42 -05:00
2020-01-07 11:56:52 -05:00
2020-01-07 11:59:37 -05:00
2020-01-07 11:58:37 -05:00
2020-02-04 23:30:39 -05:00
2020-01-27 16:46:45 -05:00
2019-10-25 16:15:00 -04:00
2020-01-16 13:37:47 -05:00
2020-02-11 15:10:36 -05:00
2020-01-22 16:34:14 -05:00
2020-01-22 16:34:14 -05:00
2020-02-04 23:30:39 -05:00
2020-02-04 23:30:39 -05:00
2020-02-26 14:17:33 -05:00
2020-02-04 23:30:39 -05:00
2019-10-07 15:11:07 -05:00
2020-02-26 14:17:32 -05:00
2020-02-26 14:17:32 -05:00
2020-02-28 15:40:26 +10:00
2019-10-03 09:11:05 -05:00
2020-01-22 16:55:27 -05:00
2019-08-12 12:47:48 -05:00
2020-01-22 16:55:27 -05:00
2019-06-20 21:35:29 -05:00
2019-06-10 23:00:01 +02:00
2019-06-10 23:04:34 +02:00
2020-02-26 14:21:13 -05:00
2019-06-10 23:04:34 +02:00
2019-11-13 15:29:44 -05:00
2019-06-10 23:04:34 +02:00
2019-12-23 14:55:44 -05:00
2020-01-14 10:18:08 -05:00
2020-01-14 10:18:08 -05:00
2019-06-20 21:16:37 -05:00
2019-06-10 23:04:34 +02:00
2020-02-13 13:08:13 +01:00
2020-02-13 13:08:13 +01:00
2020-02-13 13:08:13 +01:00
2020-02-13 13:08:13 +01:00
2020-02-28 15:40:26 +10:00
2020-01-14 10:18:58 -05:00
2020-01-22 16:34:07 -05:00
2019-06-20 11:35:45 -05:00
2019-11-13 15:29:46 -05:00
2020-02-28 16:59:21 -05:00
2020-02-28 16:59:21 -05:00
2020-02-28 16:59:21 -05:00
2020-01-30 17:15:43 -05:00
2020-01-22 16:36:30 -05:00
2020-02-28 16:59:21 -05:00
2019-06-21 18:59:23 -05:00
2020-01-07 12:00:33 -05:00
2019-12-03 11:52:11 -05:00
2020-02-26 14:17:33 -05:00
2019-10-03 09:11:04 -05:00
2019-09-16 09:59:29 -05:00
2020-01-27 16:46:45 -05:00
2020-01-16 13:34:27 -05:00
2020-02-25 11:01:57 -05:00
2020-01-07 12:03:42 -05:00
2020-01-27 16:46:44 -05:00
2019-06-20 21:35:29 -05:00
2019-06-10 23:04:34 +02:00
2019-12-18 16:09:07 -05:00
2019-11-19 10:12:49 -05:00
2020-01-22 16:55:27 -05:00
2019-11-19 10:12:50 -05:00
2020-01-22 16:55:27 -05:00
2019-11-19 10:12:50 -05:00
2019-12-11 15:22:08 -05:00
2019-06-10 23:04:34 +02:00
2019-06-10 23:04:34 +02:00
2020-01-22 16:36:30 -05:00
2019-06-25 08:42:25 -05:00
2019-07-08 13:56:02 -05:00
2020-01-22 16:55:27 -05:00
2019-08-12 12:47:48 -05:00
2020-01-22 16:55:27 -05:00
2019-10-03 09:11:05 -05:00
2020-01-22 16:55:27 -05:00
2019-12-03 11:08:24 -05:00
2019-12-18 16:33:26 -05:00
2019-12-23 15:00:00 -05:00
2019-12-11 15:22:07 -05:00
2019-12-23 15:00:01 -05:00
2019-09-16 10:09:52 -05:00
2019-04-19 11:33:27 -05:00
2020-01-22 16:55:27 -05:00
2019-06-20 21:35:30 -05:00
2019-10-03 09:11:05 -05:00
2019-06-20 21:16:38 -05:00
2019-10-03 09:11:05 -05:00
2019-10-03 09:11:05 -05:00
2019-10-03 09:11:05 -05:00
2019-09-13 17:11:03 -05:00
2019-09-13 17:11:03 -05:00
2019-09-13 17:11:03 -05:00
2019-09-13 17:11:03 -05:00
2019-09-13 17:11:03 -05:00
2020-02-19 10:36:26 -05:00
2019-09-13 17:11:03 -05:00
2020-01-22 16:55:27 -05:00
2019-08-02 10:30:39 -05:00
2019-06-20 21:16:38 -05:00
2019-12-18 16:33:26 -05:00
2019-11-22 14:27:11 -05:00
2019-11-19 12:09:13 -05:00
2020-02-25 11:01:25 -05:00
2019-11-19 12:09:13 -05:00
2019-08-12 12:47:50 -05:00
2019-12-23 14:55:44 -05:00
2019-12-23 14:55:44 -05:00
2020-01-22 16:55:27 -05:00
2020-02-26 14:17:33 -05:00
2019-06-21 18:58:21 -05:00
2020-01-22 16:55:27 -05:00
2019-06-10 23:04:34 +02:00
2019-11-22 14:35:10 -05:00
2019-06-10 23:04:34 +02:00
2019-12-17 18:47:46 +01:00
2019-11-14 14:08:39 +02:00
2019-08-27 09:17:35 -05:00
2019-11-26 09:48:57 -05:00
2020-02-12 16:04:40 -05:00
2019-11-22 14:55:19 -05:00
2019-06-11 11:51:28 -05:00
2019-06-10 23:04:34 +02:00
2019-10-03 09:11:01 -05:00
2019-10-03 09:11:01 -05:00
2020-01-14 10:18:10 -05:00
2019-12-11 15:22:07 -05:00
2019-06-14 11:44:24 +02:00
2020-01-22 16:55:27 -05:00
2020-01-22 16:55:27 -05:00
2019-10-17 17:12:34 -04:00
2019-06-14 11:44:24 +02:00
2020-01-22 16:55:27 -05:00
2020-01-22 16:55:27 -05:00
2020-02-11 15:10:36 -05:00
2019-12-18 16:09:07 -05:00
2020-02-11 15:10:36 -05:00
2020-01-27 16:46:44 -05:00
2020-02-11 15:37:22 -05:00
2019-07-18 14:18:05 -05:00
2020-01-22 16:55:27 -05:00
2019-10-03 09:11:05 -05:00
2019-10-03 09:11:05 -05:00
2020-01-14 10:18:08 -05:00
2020-01-14 10:18:08 -05:00