Frank Rowand 6eaf5653dd of: overlay: add_changeset_property() memory leak ...

commit 637392a850 upstream.

No changeset entries are created for #address-cells and #size-cells
properties, but the duplicated properties are never freed.  This
results in a memory leak which is detected by kmemleak:

 unreferenced object 0x85887180 (size 64):
   backtrace:
     kmem_cache_alloc_trace+0x1fb/0x1fc
     __of_prop_dup+0x25/0x7c
     add_changeset_property+0x17f/0x370
     build_changeset_next_level+0x29/0x20c
     of_overlay_fdt_apply+0x32b/0x6b4
     ...

Fixes: 6f75118800 ("of: overlay: validate overlay properties #address-cells and #size-cells")
Reported-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Tested-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-01-09 10:20:03 +01:00

..

unittest-data

of: overlay: check prevents multiple fragments touching same property

2018-11-08 22:12:03 -08:00

address.c

of: address: Add support for the parent DMA bus

2019-04-10 16:33:47 -05:00

base.c

of: restore old handling of cells_name=NULL in of_*_phandle_with_args()

2019-09-19 08:33:02 -05:00

device.c

of/device.c: fix the wrong comments

2019-05-01 13:41:07 -05:00

dynamic.c

of: Remove struct device_node.type pointer

2019-01-10 16:24:44 -06:00

fdt_address.c

…

fdt.c

fdt: Update CRC check for rng-seed

2019-08-27 12:27:07 +01:00

irq.c

of: irq: fix a trivial typo in a doc comment

2019-08-14 20:12:16 -06:00

Kconfig

dma-mapping: improve selection of dma_declare_coherent availability

2019-02-20 07:26:35 -07:00

kobj.c

of: overlay: add missing of_node_get() in __of_attach_node_sysfs

2018-11-08 22:10:53 -08:00

Makefile

…

of_mdio.c

of: mdio: Fix a signedness bug in of_phy_get_and_connect()

2019-09-27 10:19:09 +02:00

of_net.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428

2019-06-05 17:37:16 +02:00

of_numa.c

of, numa: Validate some distance map rules

2018-11-08 12:44:34 -06:00

of_private.h

of: __of_detach_node() - remove node from phandle cache

2018-12-21 12:42:36 -06:00

of_reserved_mem.c

of: reserved_mem: add missing of_node_put() for proper ref-counting

2019-10-23 15:15:05 -05:00

overlay.c

of: overlay: add_changeset_property() memory leak

2020-01-09 10:20:03 +01:00

pdt.c

of: Remove struct device_node.type pointer

2019-01-10 16:24:44 -06:00

platform.c

drivers: Introduce device lookup variants by of_node

2019-07-30 13:07:41 +02:00

property.c

of: property: Document that of_graph_get_endpoint_by_regs needs of_node_put

2019-04-10 09:03:03 -05:00

resolver.c

of: resolver: Add of_node_put() before return and break

2019-08-12 16:52:24 -06:00

unittest.c

of: unittest: fix memory leak in attach_node_and_children

2020-01-04 19:18:25 +01:00