moonjuice/kernel_arpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
dfd3cc1ef3e2c521ccf7c98a6ce26020cf2c0232
kernel_arpi/kernel/trace
History
Steven Rostedt (Google) b5074df412 ring-buffer: Check for NULL cpu_buffer in ring_buffer_wake_waiters() 
commit 7433632c9ff68a991bd0bc38cabf354e9d2de410 upstream.

On some machines the number of listed CPUs may be bigger than the actual
CPUs that exist. The tracing subsystem allocates a per_cpu directory with
access to the per CPU ring buffer via a cpuX file. But to save space, the
ring buffer will only allocate buffers for online CPUs, even though the
CPU array will be as big as the nr_cpu_ids.

With the addition of waking waiters on the ring buffer when closing the
file, the ring_buffer_wake_waiters() now needs to make sure that the
buffer is allocated (with the irq_work allocated with it) before trying to
wake waiters, as it will cause a NULL pointer dereference.

While debugging this, I added a NULL check for the buffer itself (which is
OK to do), and also NULL pointer checks against buffer->buffers (which is
not fine, and will WARN) as well as making sure the CPU number passed in
is within the nr_cpu_ids (which is also not fine if it isn't).

Link: https://lore.kernel.org/all/87h6zklb6n.wl-tiwai@suse.de/
Link: https://lore.kernel.org/all/CAM6Wdxc0KRJMXVAA0Y=u6Jh2V=uWB-_Fn6M4xRuNppfXzL1mUg@mail.gmail.com/
Link: https://lkml.kernel.org/linux-trace-kernel/20221101191009.1e7378c8@rorschach.local.home

Cc: stable@vger.kernel.org
Cc: Steven Noonan <steven.noonan@gmail.com>
Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1204705
Reported-by: Takashi Iwai <tiwai@suse.de>
Reported-by: Roland Ruckerbauer <roland.rucky@gmail.com>
Fixes: f3ddb74ad079 ("tracing: Wake up ring buffer waiters on closing of the file")
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-11-10 18:15:38 +01:00
..
blktrace.c
blktrace: Trace remapped requests correctly
2022-08-17 14:23:13 +02:00
bpf_trace.c
bpf: Add MEM_RDONLY for helper args that are pointers to rdonly mem.
2022-05-01 17:22:26 +02:00
bpf_trace.h
…
error_report-traces.c
…
fgraph.c
…
ftrace_internal.h
…
ftrace.c
ftrace: Fix use-after-free for dynamic ftrace_ops
2022-11-10 18:15:38 +01:00
Kconfig
tracing: Simplify the Kconfig dependency of FTRACE
2021-08-16 11:37:20 -04:00
kprobe_event_gen_test.c
tracing: kprobe: Fix memory leak in test_gen_kprobe/kretprobe_cmd()
2022-11-10 18:15:38 +01:00
Makefile
tracing: Place trace_pid_list logic into abstract functions
2022-07-29 17:25:29 +02:00
pid_list.c
tracing: Place trace_pid_list logic into abstract functions
2022-07-29 17:25:29 +02:00
pid_list.h
tracing: Place trace_pid_list logic into abstract functions
2022-07-29 17:25:29 +02:00
power-traces.c
…
preemptirq_delay_test.c
…
ring_buffer_benchmark.c
…
ring_buffer.c
ring-buffer: Check for NULL cpu_buffer in ring_buffer_wake_waiters()
2022-11-10 18:15:38 +01:00
rpm-traces.c
…
synth_event_gen_test.c
…
trace_benchmark.c
…
trace_benchmark.h
…
trace_boot.c
tracing: Initialize integer variable to prevent garbage return value
2022-06-09 10:23:21 +02:00
trace_branch.c
…
trace_clock.c
…
trace_dynevent.c
tracing: Disable "other" permission bits in the tracefs files
2021-11-18 19:16:15 +01:00
trace_dynevent.h
tracing: Add DYNAMIC flag for dynamic events
2021-08-18 18:10:32 -04:00
trace_entries.h
…
trace_eprobe.c
tracing: Move duplicate code of trace_kprobe/eprobe.c into header
2022-10-26 12:34:31 +02:00
trace_event_perf.c
tracing/perf: Fix double put of trace event when init fails
2022-08-25 11:39:57 +02:00
trace_events_filter_test.h
…
trace_events_filter.c
tracing: Add ustring operation to filtering string pointers
2022-03-08 19:12:33 +01:00
trace_events_hist.c
tracing/histograms: Fix memory leak problem
2022-07-21 21:24:11 +02:00
trace_events_inject.c
…
trace_events_synth.c
tracing: Fix reading strings from synthetic events
2022-10-26 12:34:32 +02:00
trace_events_trigger.c
tracing: Fix to check event_mutex is held while accessing trigger list
2022-09-15 11:30:02 +02:00
trace_events.c
tracing: Have filter accept "common_cpu" to be consistent
2022-08-25 11:39:58 +02:00
trace_export.c
…
trace_functions_graph.c
tracing: Disable "other" permission bits in the tracefs files
2021-11-18 19:16:15 +01:00
trace_functions.c
…
trace_hwlat.c
tracing: Disable "other" permission bits in the tracefs files
2021-11-18 19:16:15 +01:00
trace_irqsoff.c
…
trace_kdb.c
kdb: Rename members of struct kdbtab_t
2021-07-27 17:05:06 +01:00
trace_kprobe_selftest.c
…
trace_kprobe_selftest.h
…
trace_kprobe.c
tracing: Move duplicate code of trace_kprobe/eprobe.c into header
2022-10-26 12:34:31 +02:00
trace_mmiotrace.c
…
trace_nop.c
…
trace_osnoise.c
tracing/osnoise: Fix possible recursive locking in stop_per_cpu_kthreads
2022-10-26 12:35:27 +02:00
trace_output.c
tracing: Add migrate-disabled counter to tracing output.
2021-09-03 19:42:35 -04:00
trace_output.h
…
trace_preemptirq.c
tracing: hold caller_addr to hardirq_{enable,disable}_ip
2022-09-20 12:39:43 +02:00
trace_printk.c
tracing: Disable "other" permission bits in the tracefs files
2021-11-18 19:16:15 +01:00
trace_probe_kernel.h
tracing: Add "(fault)" name injection to kernel probes
2022-10-26 12:34:32 +02:00
trace_probe_tmpl.h
tracing/probes: Have process_fetch_insn() take a void * instead of pt_regs
2021-08-19 09:09:03 -04:00
trace_probe.c
tracing/probes: Have kprobes and uprobes use $COMM too
2022-08-25 11:39:58 +02:00
trace_probe.h
tracing: Add a probe that attaches to trace events
2021-08-20 14:18:40 -04:00
trace_recursion_record.c
tracing: Disable "other" permission bits in the tracefs files
2021-11-18 19:16:15 +01:00
trace_sched_switch.c
…
trace_sched_wakeup.c
tracing: Change variable type as bool for clean-up
2021-06-30 09:19:14 -04:00
trace_selftest_dynamic.c
…
trace_selftest.c
…
trace_seq.c
…
trace_stack.c
tracing: Disable "other" permission bits in the tracefs files
2021-11-18 19:16:15 +01:00
trace_stat.c
tracing: Disable "other" permission bits in the tracefs files
2021-11-18 19:16:15 +01:00
trace_stat.h
…
trace_synth.h
tracing: synth events: increase max fields count
2021-09-08 15:29:16 -04:00
trace_syscalls.c
tracing: Make tp_printk work on syscall tracepoints
2022-06-14 18:36:14 +02:00
trace_uprobe.c
tracing/uprobes: Check the return value of kstrdup() for tu->filename
2022-03-08 19:12:38 +01:00
trace.c
tracing: Do not free snapshot if tracer is on cmdline
2022-10-29 10:12:58 +02:00
trace.h
tracing: Add '__rel_loc' using trace event macros
2022-08-17 14:24:26 +02:00
tracing_map.c
tracing: Fix a kmemleak false positive in tracing_map
2021-12-17 10:30:16 +01:00
tracing_map.h
…