Jeff Layton 24cbe7845e
locks: close potential race between setlease and open ...
As Al Viro points out, there is an unlikely, but possible race between
opening a file and setting a lease on it. generic_add_lease is done with
the i_lock held, but the inode->i_flock check in break_lease is
lockless. It's possible for another task doing an open to do the entire
pathwalk and call break_lease between the point where generic_add_lease
checks for a conflicting open and adds the lease to the list. If this
occurs, we can end up with a lease set on the file with a conflicting
open.
To guard against that, check again for a conflicting open after adding
the lease to the i_flock list. If the above race occurs, then we can
simply unwind the lease setting and return -EAGAIN.
Because we take dentry references and acquire write access on the file
before calling break_lease, we know that if the i_flock list is empty
when the open caller goes to check it then the necessary refcounts have
already been incremented. Thus the additional check for a conflicting
open will see that there is one and the setlease call will fail.
Cc: Bruce Fields <bfields@fieldses.org >
Cc: David Howells <dhowells@redhat.com >
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com >
Reported-by: Al Viro <viro@ZenIV.linux.org.uk >
Signed-off-by: Jeff Layton <jlayton@redhat.com >
Signed-off-by: J. Bruce Fields <bfields@fieldses.org >
2014-03-31 08:24:42 -04:00
2014-01-02 10:46:41 +01:00
2014-01-30 17:20:32 -08:00
2014-01-30 11:19:05 -08:00
2014-01-28 18:44:53 -08:00
2013-12-31 20:32:26 +02:00
2014-01-09 09:53:30 +09:00
2013-12-09 14:18:33 +01:00
2014-01-24 17:17:30 -08:00
2013-12-08 13:13:52 +00:00
2014-01-25 10:49:30 -08:00
2014-01-28 18:53:01 -08:00
2014-01-25 11:17:34 -08:00
2014-01-22 23:23:54 -08:00
2014-01-26 11:00:41 -08:00
2014-01-20 11:55:23 -08:00
2014-01-03 23:41:35 +01:00
2013-12-23 14:26:17 -06:00
2014-01-16 14:25:37 +01:00
2014-01-31 09:31:14 -08:00
2013-12-23 18:34:58 -08:00
2013-12-24 13:47:40 +00:00
2014-01-31 08:59:46 -08:00
2014-01-25 13:20:36 -08:00
2014-01-24 22:39:54 +01:00
2014-01-30 10:18:43 -08:00
2014-01-23 18:49:36 -08:00
2013-12-08 18:01:56 -08:00
2014-01-17 01:59:38 +01:00
2013-12-02 11:24:18 +00:00
2013-12-09 15:37:58 -05:00
2014-01-14 14:54:00 -05:00
2013-12-24 09:35:17 -08:00
2014-01-28 08:09:46 -07:00
2014-01-30 16:56:54 -08:00
2014-01-30 16:56:54 -08:00
2014-01-13 17:32:27 +01:00
2014-01-23 16:36:56 -08:00
2014-01-15 11:33:40 +08:00
2014-01-03 23:41:42 +01:00
2014-01-13 10:48:18 -05:00
2013-12-31 11:35:12 -08:00
2014-01-30 17:07:18 -08:00
2013-12-22 23:14:27 -08:00
2013-12-04 17:19:44 +01:00
2014-01-21 20:18:26 -08:00
2014-01-21 16:19:48 -08:00
2014-02-01 10:43:45 -08:00
2013-12-05 21:28:41 +08:00
2014-01-23 18:11:00 -08:00
2014-01-23 18:11:00 -08:00
2014-01-10 16:27:36 -08:00
2013-12-29 15:25:48 +01:00
2013-12-02 20:43:15 +01:00
2013-12-02 20:43:14 +01:00
2013-12-04 09:33:34 -04:00
2014-01-17 02:00:44 +01:00
2014-01-15 14:19:42 +07:00
2013-12-12 10:39:01 -08:00
2014-01-13 14:05:13 -08:00
2014-01-09 12:43:40 +01:00
2014-01-21 16:19:41 -08:00
2014-01-29 20:27:23 -08:00
2014-01-09 12:43:37 +01:00
2013-12-11 18:06:47 +01:00
2014-01-05 12:34:29 +01:00
2014-01-15 15:39:33 -08:00
2014-01-16 10:23:02 +10:30
2014-01-06 16:42:20 +09:00
2013-12-18 10:56:13 +10:00
2014-01-25 03:14:36 -05:00
2014-01-21 18:57:43 -08:00
2013-12-08 18:22:32 -08:00
2014-01-21 23:17:20 -08:00
2014-03-31 08:24:42 -04:00
2014-01-29 13:57:10 +01:00
2014-01-09 21:20:07 -05:00
2014-01-02 16:17:12 -05:00
2014-01-23 16:36:52 -08:00
2014-01-23 16:36:50 -08:00
2014-01-13 17:32:27 +01:00
2013-12-17 14:27:17 -05:00
2013-12-02 21:05:30 +00:00
2013-12-24 10:30:57 -08:00
2013-12-19 09:29:43 +01:00
2014-01-21 16:19:43 -08:00
2014-01-23 16:36:50 -08:00
2014-01-23 16:36:50 -08:00
2014-01-16 11:15:50 +01:00
2014-01-29 20:40:08 +01:00
2014-01-26 22:48:35 +01:00
2013-12-07 01:03:14 +01:00
2014-01-10 20:12:13 +01:00
2014-01-04 20:11:33 -05:00
2014-01-04 20:10:24 -05:00
2014-01-05 20:27:55 -05:00
2013-12-29 16:34:25 -05:00
2013-12-11 14:47:40 -05:00
2014-01-23 18:08:10 -08:00
2013-12-10 22:58:13 -08:00
2014-01-09 12:43:40 +01:00
2014-01-27 21:02:40 -08:00
2014-01-09 13:06:59 +01:00
2014-01-27 21:02:40 -08:00
2014-01-27 21:02:39 -08:00
2014-01-19 19:53:18 -08:00
2013-12-19 17:43:04 +00:00
2013-12-07 01:24:33 +01:00
2014-01-16 00:08:12 +01:00
2014-01-08 15:23:53 +00:00
2014-01-25 11:17:34 -08:00
2014-01-17 11:50:07 -08:00
2014-01-23 16:37:03 -08:00
2014-01-25 08:55:09 +01:00
2013-12-11 15:28:36 -08:00
2014-01-21 16:19:45 -08:00
2014-01-08 19:03:00 -02:00
2014-01-16 09:49:10 -05:00
2014-01-27 21:45:29 +01:00
2013-12-20 12:25:45 -08:00
2013-12-11 15:52:34 +01:00
2013-12-26 13:29:35 -05:00
2014-01-23 16:36:51 -08:00
2014-01-23 16:36:51 -08:00
2013-12-20 12:20:26 -08:00
2014-01-21 16:19:44 -08:00
2013-12-11 13:54:13 -05:00
2014-01-21 16:19:49 -08:00
2013-12-19 10:17:11 -07:00
2013-12-20 12:25:45 -08:00
2014-01-27 21:11:26 -08:00
2014-01-21 16:19:44 -08:00
2014-01-23 16:36:50 -08:00
2014-01-21 16:19:48 -08:00
2014-01-16 10:23:03 +10:30
2014-01-27 21:02:39 -08:00
2013-12-13 08:44:30 -07:00
2014-01-14 15:15:25 -08:00
2014-01-22 21:57:17 -08:00
2014-01-01 23:43:36 -05:00
2013-12-05 13:05:48 -08:00
2014-01-31 15:39:07 -08:00
2014-01-25 03:14:05 -05:00
2014-01-17 01:59:15 +01:00
2014-01-09 17:52:17 -06:00
2014-01-13 14:29:49 -08:00
2014-01-03 11:22:21 -08:00
2014-01-23 16:36:55 -08:00
2014-01-23 16:36:50 -08:00
2014-01-23 16:36:50 -08:00
2014-01-23 16:36:55 -08:00
2013-12-07 01:03:14 +01:00
2014-01-10 14:00:47 -07:00
2014-01-22 16:39:28 -08:00
2014-01-23 20:17:18 +00:00
2013-12-05 12:59:23 -05:00
2014-01-23 16:36:50 -08:00
2014-01-12 10:16:07 +01:00
2014-01-13 14:29:49 -08:00
2014-01-22 19:36:57 +01:00
2013-12-22 01:39:58 +01:00
2014-01-12 23:50:03 +01:00
2014-01-25 23:58:17 -05:00
2014-01-28 08:38:04 -08:00
2013-12-23 18:21:11 -08:00
2014-01-13 17:32:27 +01:00
2014-01-23 14:48:35 +01:00
2014-01-25 11:17:34 -08:00
2013-12-20 13:12:01 -08:00
2014-01-23 16:36:58 -08:00
2014-01-21 23:17:20 -08:00
2013-12-12 12:34:16 -08:00
2014-01-28 08:38:04 -08:00
2013-12-12 12:34:16 -08:00
2013-12-12 12:34:16 -08:00
2013-12-18 19:04:50 -08:00
2014-01-21 23:17:20 -08:00
2014-01-09 14:34:13 +00:00
2014-01-16 12:00:56 -08:00
2014-01-21 16:19:45 -08:00
2014-01-13 13:41:50 +01:00
2013-12-17 21:19:08 -08:00
2014-01-13 13:47:36 +01:00
2014-01-28 13:20:09 -08:00
2013-12-08 17:56:37 -08:00
2014-01-23 16:37:02 -08:00
2014-01-19 19:55:50 -08:00
2014-01-12 10:13:59 +01:00
2014-01-23 13:02:36 +01:00
2013-12-24 21:50:54 +09:00
2013-12-07 01:24:33 +01:00
2013-12-19 19:09:38 -05:00
2014-01-27 21:02:39 -08:00
2013-12-02 11:24:19 +00:00
2014-01-26 22:38:23 -08:00
2014-01-25 11:17:34 -08:00
2014-02-02 11:30:08 -08:00
2014-01-30 16:56:54 -08:00
2014-01-22 21:57:05 -08:00
2014-01-13 13:47:36 +01:00
2014-01-13 13:47:36 +01:00
2013-12-16 11:36:13 +01:00
2014-01-27 21:02:40 -08:00
2014-01-21 08:28:07 +00:00
2014-01-21 17:05:27 -08:00
2014-01-13 13:41:04 +01:00
2014-01-13 14:05:13 -08:00
2013-12-07 01:03:14 +01:00
2014-01-06 16:34:34 -05:00
2014-01-14 08:01:10 -08:00
2013-12-04 09:31:34 -04:00
2014-01-15 23:05:31 +01:00
2014-01-06 14:37:25 +01:00
2013-12-19 15:08:32 +01:00
2013-12-09 11:09:24 -08:00
2013-12-08 16:56:05 -08:00
2014-01-20 16:13:02 -08:00
2014-01-13 13:47:37 +01:00
2014-01-10 16:54:35 -08:00
2013-12-03 11:15:58 -08:00
2014-01-29 16:22:39 -08:00
2013-12-02 20:43:15 +01:00
2014-01-23 16:37:04 -08:00
2014-01-22 10:25:39 +01:00
2014-01-30 16:56:55 -08:00
24cbe7845e